I had not tested it using other compilers. Thanks for your fix them. Reviewed-by: Chen Fan <chen.fan.f...@cn.fujitsu.com>
Chen On Wed, 2014-11-19 at 03:12 +0000, Fan, Jeff wrote: > !!() cannot pass VS2005 build. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Jeff Fan <jeff....@intel.com> > > > > > > Index: CpuDxe/CpuMp.c > > =================================================================== > > --- CpuDxe/CpuMp.c (revision 16401) > > +++ CpuDxe/CpuMp.c (working copy) > > @@ -178,7 +178,7 @@ > > Ret = CpuData->Info.StatusFlag & Flags; > > ReleaseMpSpinLock (CpuData); > > - return !!(Ret); > > + return (Ret != 0); > > } > > /** > > @@ -664,7 +664,7 @@ > > mMpSystemData.ProcedureArgument = ProcedureArgument; > > mMpSystemData.WaitEvent = WaitEvent; > > mMpSystemData.Timeout = TimeoutInMicroseconds; > > - mMpSystemData.TimeoutActive = !!(TimeoutInMicroseconds); > > + mMpSystemData.TimeoutActive = (TimeoutInMicroseconds != 0); > > mMpSystemData.FinishCount = 0; > > mMpSystemData.StartCount = 0; > > mMpSystemData.SingleThread = SingleThread; > > @@ -887,7 +887,7 @@ > > CpuData->Timeout = TimeoutInMicroseconds; > > CpuData->WaitEvent = WaitEvent; > > - CpuData->TimeoutActive = !!(TimeoutInMicroseconds); > > + CpuData->TimeoutActive = (TimeoutInMicroseconds != 0); > > CpuData->Finished = Finished; > > mStopCheckAllAPsStatus = FALSE; > > > > ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
