On 2014-11-18 23:49:45, Gao, Liming wrote:
> Nasmb can replace ASM16. Now, ASM16 output file is *.com. To be
> compatible with it, update nasmb build rule to output *.com file
> also.
> 
> ASM16 output file is used by Platform FDF Rule section. With this
> patch, Platform FDF file will not be impacted after asm16 file is
> converted to nasmb file.

Liming,

I don't think we need this change. With a small change to the .fdf,
.bin can work as easily as .com.

I think .com was a bad extension for this file, even when
masm16/link16 was being used. Maybe we should have copied from .com to
.bin before.

-Jordan

> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao <liming....@intel.com>
> 
> ---
> 
> Index: build_rule.template
> 
> ===================================================================
> 
> --- build_rule.template (revision 16400)
> 
> +++ build_rule.template              (working copy)
> 
> @@ -491,8 +491,8 @@
> 
>          "$(PP)" $(PP_FLAGS) $(INC) ${src} > ${d_path}(+)${s_base}.i
> 
>          Trim --source-code --convert-hex -o ${d_path}(+)${s_base}.iii $
> {d_path}(+)${s_base}.i
> 
>          "$(NASM)" -I${s_path}(+) -l ${d_path}(+)${s_base}.lst $(NASMB_FLAGS)
> -o $dst ${d_path}(+)${s_base}.iii
> 
> +        $(CP) ${dst} $(OUTPUT_DIR)(+)${s_base}.com
> 
> -
> 
> [Microcode-File.USER_DEFINED, Microcode-File.Microcode]
> 
>      <InputFile>
> 
>          ?.txt, ?.TXT, ?.Txt, ?.mut, ?.inc
> 
> ---
> 
>  
> 
> Thanks
> 
> Liming
> 
>  
> 

------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to