Thanks for your contribution, Randy.
Just a minor comment:
El-Haj-Mahmoud, Samer proposed a different fix for I2cHost.c. I think his
change adding a debug message is more appropriate. Do you agree? (Of cause I
would suggest him to add \n link break at the debug message.)
@@ -672,6 +673,10 @@
I2cHostContext->I2cEvent,
&I2cHostContext->Status
);
+
+ if (EFI_ERROR (Status)) {
+ DEBUG((DEBUG_ERROR, "%a: error starting I2C operation, %r", __FUNCTION__,
Status));
+ }
Others look good to me.
Reviewed-by: Feng Tian <[email protected]>
Thanks
Feng
-----Original Message-----
From: Pawell, Randy [mailto:[email protected]]
Sent: Wednesday, November 26, 2014 05:43
To: [email protected]; Tian, Feng; [email protected]
Subject: [edk2] MdeModulePkg: Source fixes and cleanup for ARMGCC compiles
Please review the attached MdeModulePkg patch.
Thanks,
Randy Pawell
____________________________________________________________________________
MdeModulePkg: Source fixes and cleanup for ARMGCC compiles
- Fix EFI_IPv4_ADDRESS usages to use a macro or CopyMem() to copy the
structure instead of direct assignment, to avoid runtime alignment errors.
- Fix a EFI_INPUT_KEY usage in TerminalDxe to use CopyMem() to copy the
structure instead of direct assignment, to avoid runtime alignment error.
- Delete excess local variables that are initialized but otherwise unused.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Randy Pawell <[email protected]>
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
