Re: [edk2] DuetPkg: correct print formatting problem for gcc X64 build

[Scott Duplichan]

Laszlo Ersek [mailto:ler...@redhat.com] wrote:

Sent: Monday, November 03, 2014 10:34 AM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] DuetPkg: correct print formatting problem for gcc X64 build

]On 10/29/14 05:32, Scott Duplichan wrote:
]> Without patch:
]>     LoadPe: new image base 7FE88000
]>     DxeCore PE image is successed loaded at 0, entry=130000
]> 
]>     EFI Memory Descriptors
]>     Type = 0 Start = 00130000 NumberOfPages = 00000000
]>     Type = 0 Start = 00130000 NumberOfPages = 00000000
]> 
]> With patch:
]>     LoadPe: new image base 7FE88000
]>     DxeCore PE image is successed loaded at 7FE7F000, entry=7FE88260
]> 
]>     EFI Memory Descriptors
]>     Type = 7 Start = 00000000 NumberOfPages = 0000009F
]>     Type = 0 Start = 0009F000 NumberOfPages = 00000001
]> 
]> The cause is discussed here:
]> https://www.mail-archive.com/edk2-devel@lists.sourceforge.net/msg06340.html
]> 
]> -- DuetPkg: Fix incorrect print formatting when built for X64 mode using
]> gcc. Contributed-under: TianoCore Contribution Agreement 1.0
]> Signed-off-by: Scott Duplichan <sc...@notabs.org> -- Index:
]> DuetPkg/DxeIpl/Debug.c
]> =================================================================== ---
]> DuetPkg/DxeIpl/Debug.c (revision 16220) +++ DuetPkg/DxeIpl/Debug.c
]> (working copy) @@ -52,6 +52,7 @@ } VOID +EFIAPI PrintString ( IN CONST
]> CHAR8 *FormatString, ... Index: DuetPkg/DxeIpl/Debug.h
]> =================================================================== ---
]> DuetPkg/DxeIpl/Debug.h (revision 16220) +++ DuetPkg/DxeIpl/Debug.h
]> (working copy) @@ -27,6 +27,7 @@ ); VOID +EFIAPI PrintString ( IN CONST
]> CHAR8 *FormatString, ... Index: DuetPkg/EfiLdr/Debug.c
]> =================================================================== ---
]> DuetPkg/EfiLdr/Debug.c (revision 16220) +++ DuetPkg/EfiLdr/Debug.c
]> (working copy) @@ -49,6 +49,7 @@ } VOID +EFIAPI PrintString ( IN CONST
]> CHAR8 *FormatString, ... Index: DuetPkg/EfiLdr/Debug.h
]> =================================================================== ---
]> DuetPkg/EfiLdr/Debug.h (revision 16220) +++ DuetPkg/EfiLdr/Debug.h
]> (working copy) @@ -27,6 +27,7 @@ ); VOID +EFIAPI PrintString ( IN CONST
]> CHAR8 *FormatString, ...
]> -- Thanks, Scott
]> 
]> 
]> duet-print-fix.patch
]> 
]> 
]> Index: DuetPkg/DxeIpl/Debug.c
]> ===================================================================
]> --- DuetPkg/DxeIpl/Debug.c   (revision 16220)
]> +++ DuetPkg/DxeIpl/Debug.c   (working copy)
]> @@ -52,6 +52,7 @@
]>  }
]>  
]>  VOID
]> +EFIAPI
]>  PrintString (
]>    IN CONST CHAR8  *FormatString,
]>    ...
]> Index: DuetPkg/DxeIpl/Debug.h
]> ===================================================================
]> --- DuetPkg/DxeIpl/Debug.h   (revision 16220)
]> +++ DuetPkg/DxeIpl/Debug.h   (working copy)
]> @@ -27,6 +27,7 @@
]>    );
]>  
]>  VOID
]> +EFIAPI
]>  PrintString (
]>    IN CONST CHAR8  *FormatString,
]>    ...
]> Index: DuetPkg/EfiLdr/Debug.c
]> ===================================================================
]> --- DuetPkg/EfiLdr/Debug.c   (revision 16220)
]> +++ DuetPkg/EfiLdr/Debug.c   (working copy)
]> @@ -49,6 +49,7 @@
]>  }
]>  
]>  VOID
]> +EFIAPI
]>  PrintString (
]>    IN CONST CHAR8  *FormatString,
]>    ...
]> Index: DuetPkg/EfiLdr/Debug.h
]> ===================================================================
]> --- DuetPkg/EfiLdr/Debug.h   (revision 16220)
]> +++ DuetPkg/EfiLdr/Debug.h   (working copy)
]> @@ -27,6 +27,7 @@
]>    );
]>  
]>  VOID
]> +EFIAPI
]>  PrintString (
]>    IN CONST CHAR8  *FormatString,
]>    ...
]> 
]> 
]> 
]> 
------------------------------------------------------------------------------
]> 
]> 
]> 
]> _______________________________________________
]> edk2-devel mailing list
]> edk2-devel@lists.sourceforge.net
]> https://lists.sourceforge.net/lists/listinfo/edk2-devel
]> 
]
]Reviewed-by: Laszlo Ersek <ler...@redhat.com>

Thanks Laszlo.

Hello Ray,

Can you commit this? I use Duet to boot test and this patch
prevents problems with the gcc X64 build of Duet.

Thanks,
Scott

]------------------------------------------------------------------------------



------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel