Reviewed-By: Olivier Martin <olivier.mar...@arm.com> I can see this patch has not been merged. Dennis, are you happy to do it?
> -----Original Message----- > From: Liu, Yingke D [mailto:yingke.d....@intel.com] > Sent: 24 November 2014 01:56 > To: Scott Duplichan; edk2-devel@lists.sourceforge.net > Subject: Re: [edk2] [PATCH] BaseTools: Fix ARM build failure with gcc > 4.6 > > Scott, > > Patch looks good to me. > Reviewed-by: Yingke Liu <yingke.d....@intel.com> > > Dennis > > -----Original Message----- > From: Scott Duplichan [mailto:sc...@notabs.org] > Sent: Thursday, November 20, 2014 3:46 AM > To: edk2-devel@lists.sourceforge.net > Cc: Liu, Yingke D > Subject: [PATCH] BaseTools: Fix ARM build failure with gcc 4.6 > > BaseTools: Fix ARM build failure with gcc 4.6. Gcc option -mno- > unaligned-access is supported by gcc 4.7 and newer, so it shouldn't be > used with gcc 4.6. > https://gcc.gnu.org/gcc-4.7/changes.html > > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Scott Duplichan <sc...@notabs.org> > --- > > Index: BaseTools/Conf/tools_def.template > =================================================================== > --- BaseTools/Conf/tools_def.template (revision 16408) > +++ BaseTools/Conf/tools_def.template (working copy) > @@ -3866,7 +3866,7 @@ > DEFINE GCC46_X64_DLINK_FLAGS = DEF(GCC45_X64_DLINK_FLAGS) > DEFINE GCC46_ASM_FLAGS = DEF(GCC45_ASM_FLAGS) > DEFINE GCC46_ARM_ASM_FLAGS = $(ARCHASM_FLAGS) > $(PLATFORM_FLAGS) DEF(GCC_ASM_FLAGS) -mlittle-endian > -DEFINE GCC46_ARM_CC_FLAGS = $(ARCHCC_FLAGS) > $(PLATFORM_FLAGS) DEF(GCC44_ALL_CC_FLAGS) DEF(GCC_ARM_CC_FLAGS) -mno- > unaligned-access -fstack-protector > +DEFINE GCC46_ARM_CC_FLAGS = $(ARCHCC_FLAGS) > $(PLATFORM_FLAGS) DEF(GCC44_ALL_CC_FLAGS) DEF(GCC_ARM_CC_FLAGS) - > fstack-protector > DEFINE GCC46_ARM_DLINK_FLAGS = > DEF(GCC_ARM_AARCH64_DLINK_COMMON) --oformat=elf32-littlearm > DEFINE GCC46_ARM_ASLDLINK_FLAGS = > DEF(GCC_ARM_AARCH64_ASLDLINK_FLAGS) --oformat=elf32-littlearm > > @@ -3879,7 +3879,7 @@ > DEFINE GCC47_ASM_FLAGS = DEF(GCC46_ASM_FLAGS) > DEFINE GCC47_ARM_ASM_FLAGS = DEF(GCC46_ARM_ASM_FLAGS) > DEFINE GCC47_AARCH64_ASM_FLAGS = $(ARCHASM_FLAGS) > $(PLATFORM_FLAGS) DEF(GCC_ASM_FLAGS) -mlittle-endian > -DEFINE GCC47_ARM_CC_FLAGS = DEF(GCC46_ARM_CC_FLAGS) > +DEFINE GCC47_ARM_CC_FLAGS = DEF(GCC46_ARM_CC_FLAGS) -mno- > unaligned-access > DEFINE GCC47_AARCH64_CC_FLAGS = $(ARCHCC_FLAGS) > $(PLATFORM_FLAGS) DEF(GCC44_ALL_CC_FLAGS) DEF(GCC_AARCH64_CC_FLAGS) > DEFINE GCC47_ARM_DLINK_FLAGS = DEF(GCC46_ARM_DLINK_FLAGS) > DEFINE GCC47_AARCH64_DLINK_FLAGS = > DEF(GCC_ARM_AARCH64_DLINK_COMMON) > > > --- > > Thanks, > Scott > ----------------------------------------------------------------------- > ------- > Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server > from Actuate! Instantly Supercharge Your Business Reports and > Dashboards > with Interactivity, Sharing, Native Excel Exports, App Integration & > more > Get technology previously reserved for billion-dollar corporations, > FREE > http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.c > lktrk > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
