Pawell I will follow our process to review and check in it, thanks.
Best Regards Siyuan -----Original Message----- From: Pawell, Randy [mailto:randy.paw...@hp.com] Sent: Tuesday, December 02, 2014 3:48 AM To: Olivier Martin; edk2-devel@lists.sourceforge.net; Fu, Siyuan Subject: RE: [edk2][PATCH v2] NetworkPkg: Source fixes and cleanup for ARMGCC compile Please re-review the attached NetworkPkg patch. Feedback from both of my open reviews has been incorporated. Thanks, Randy Pawell _______________________________________________________________________ NetworkPkg: Source fixes and cleanup for ARMGCC compiles - Fix EFI_IPv4_ADDRESS usages to use a macro to copy the structure instead of direct assignment, to avoid runtime alignment errors. - Delete excess local variables that are initialized but otherwise unused. - Add LibraryClasses.ARM & AARCH64 section in NetworkPkg.dsc file, containing a CompilerIntrinsicsLib null-library, required for successful standalone package builds (copied from MdeModulePkg.dsc). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Randy Pawell <randy_paw...@hp.com> -----Original Message----- From: Olivier Martin [mailto:olivier.mar...@arm.com] Sent: Monday, December 01, 2014 8:51 AM To: Pawell, Randy; edk2-devel@lists.sourceforge.net; siyuan...@intel.com Subject: RE: [edk2] NetworkPkg: Source fixes and cleanup for ARMGCC compile I would also suggest to add CompilerIntrinsicsLib.inf to LibraryClasses.AARCH64: [LibraryClasses.ARM, LibraryClasses.AARCH64] # # It is not possible to prevent ARM compiler calls to generic intrinsic functions. # This library provides the instrinsic functions generated by a given compiler. # [LibraryClasses.ARM] and NULL mean link this library into all ARM images. # NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf Reviewed-By: Olivier Martin <olivier.mar...@arm.com> > -----Original Message----- > From: Pawell, Randy [mailto:randy.paw...@hp.com] > Sent: 25 November 2014 21:44 > To: edk2-devel@lists.sourceforge.net; siyuan...@intel.com; Olivier > Martin > Subject: [edk2] NetworkPkg: Source fixes and cleanup for ARMGCC > compile > > Please review the attached NetworkPkg patch. > > Thanks, > Randy Pawell > ______________________________________________________________________ > _ > _____________________________ > > NetworkPkg: Source fixes and cleanup for ARMGCC compiles > - Fix EFI_IPv4_ADDRESS usages to use a macro to copy the structure > instead of direct assignment, to avoid runtime alignment errors. > - Delete excess local variables that are initialized but otherwise > unused. > - Add a LibraryClasses.ARM section in NetworkPkg.dsc file, containing a > CompilerIntrinsicsLib null-library, required for successful > standalone > package builds (copied from MdeModulePkg.dsc). > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Randy Pawell <randy_paw...@hp.com> ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
