Ok, looks good to me. Reviewed-by: Feng Tian <feng.t...@intel.com>
-----Original Message----- From: Pawell, Randy [mailto:randy.paw...@hp.com] Sent: Wednesday, December 03, 2014 03:06 To: Tian, Feng; Olivier Martin; edk2-devel@lists.sourceforge.net Subject: RE: [edk2][PATCH v3] MdeModulePkg: Source fixes and cleanup for ARMGCC compiles Thanks. The revised copyright format is correct per our legal department. Previously other source changes may have been contributed using older copyright formats. -Randy -----Original Message----- From: Tian, Feng [mailto:feng.t...@intel.com] Sent: Monday, December 01, 2014 4:36 PM To: Pawell, Randy; Olivier Martin; edk2-devel@lists.sourceforge.net Cc: Tian, Feng Subject: RE: [edk2][PATCH v3] MdeModulePkg: Source fixes and cleanup for ARMGCC compiles Hi, Randy, In your patch, you are using: + (C) Copyright 2014 Hewlett-Packard Development Company, L.P.<BR> But in previous MdePkg/MdeModulePkg check-ins, the format was: + Copyright (c) 2014, Hewlett-Packard Development Company, L.P.<BR> I am not sure if it's a problem. Please double confirm it. Thanks Feng -----Original Message----- From: Pawell, Randy [mailto:randy.paw...@hp.com] Sent: Tuesday, December 02, 2014 03:48 To: Olivier Martin; edk2-devel@lists.sourceforge.net; Tian, Feng Subject: RE: [edk2][PATCH v3] MdeModulePkg: Source fixes and cleanup for ARMGCC compiles Please re-review the attached MdeModulePkg patch. Feedback from both of my open reviews has been incorporated. Thanks, Randy Pawell _______________________________________________________________________ MdeModulePkg: Source fixes and cleanup for ARMGCC compiles - Fix EFI_IPv4_ADDRESS usages to use a macro to copy the structure instead of direct assignment, to avoid runtime alignment errors. - Fix a EFI_INPUT_KEY usage in TerminalDxe to use CopyMem() to copy the structure instead of direct assignment, to avoid runtime alignment error. - Delete excess local variables that are initialized but otherwise unused. - CompilerIntrinsicsLib library now imported for AARCH64, as well as ARM. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Randy Pawell <randy_paw...@hp.com> -----Original Message----- From: Olivier Martin [mailto:olivier.mar...@arm.com] Sent: Monday, December 01, 2014 7:46 AM To: Pawell, Randy; edk2-devel@lists.sourceforge.net; feng.t...@intel.com Subject: RE: [edk2] MdeModulePkg: Source fixes and cleanup for ARMGCC compiles I have not see anything controversial and I do not disagree with Feng's comments. These patches (this one and the one on 2014-11-26) look good to me. Reviewed-By: Olivier Martin <olivier.mar...@arm.com> > -----Original Message----- > From: Pawell, Randy [mailto:randy.paw...@hp.com] > Sent: 25 November 2014 21:43 > To: edk2-devel@lists.sourceforge.net; feng.t...@intel.com; Olivier > Martin > Subject: [edk2] MdeModulePkg: Source fixes and cleanup for ARMGCC > compiles > > Please review the attached MdeModulePkg patch. > > Thanks, > Randy Pawell > ______________________________________________________________________ > _ > _____ > > MdeModulePkg: Source fixes and cleanup for ARMGCC compiles > - Fix EFI_IPv4_ADDRESS usages to use a macro or CopyMem() to copy the > structure instead of direct assignment, to avoid runtime alignment > errors. > - Fix a EFI_INPUT_KEY usage in TerminalDxe to use CopyMem() to copy > the > structure instead of direct assignment, to avoid runtime alignment > error. > - Delete excess local variables that are initialized but otherwise > unused. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Randy Pawell <randy_paw...@hp.com> ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
