Thanks for reminder, Andrew. I mix them up☺
The patch is good to me
Reviewed-by: Feng Tian <[email protected]>
From: Andrew Fish [mailto:[email protected]]
Sent: Friday, December 12, 2014 09:01
To: [email protected]
Subject: Re: [edk2] [PATCH] MdeModulePkg/DxeCore: Fixed compiler error
'enumerated type mixed with another type'
On Dec 11, 2014, at 4:45 PM, Tian, Feng
<[email protected]<mailto:[email protected]>> wrote:
Hi, Olivier
A little curious why you don’t meet same issue with SmmCoreUpdateProfile()
caller in Pool.c and Page.c of PiSmmCore.
They use 0 as a passed-in parameter and have no such force type cast as well.
(Pool.c of PiSmmCore line 319 and Pag.c of PiSmmCore line 347)
They don’t build for ARM…
https://svn.code.sf.net/p/edk2/code/trunk/edk2/MdeModulePkg/MdeModulePkg.dsc
[Components.IA32, Components.X64, Components.IPF]
MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
MdeModulePkg/Universal/DebugSupportDxe/DebugSupportDxe.inf
MdeModulePkg/Universal/EbcDxe/EbcDxe.inf
[Components.IA32, Components.X64, Components.Ebc]
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf
MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf
[Components.IA32, Components.X64]
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf
MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf
MdeModulePkg/Library/SmmReportStatusCodeLib/SmmReportStatusCodeLib.inf
MdeModulePkg/Universal/StatusCodeHandler/Smm/StatusCodeHandlerSmm.inf
MdeModulePkg/Universal/ReportStatusCodeRouter/Smm/ReportStatusCodeRouterSmm.inf
MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf
MdeModulePkg/Library/SmmCorePerformanceLib/SmmCorePerformanceLib.inf
MdeModulePkg/Library/SmmPerformanceLib/SmmPerformanceLib.inf
MdeModulePkg/Library/DxeSmmPerformanceLib/DxeSmmPerformanceLib.inf
MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf
MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxSmmLib.inf
MdeModulePkg/Library/SmmCorePlatformHookLibNull/SmmCorePlatformHookLibNull.inf
MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/BootScriptExecutorDxe.inf
MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf
MdeModulePkg/Universal/Acpi/SmmS3SaveState/SmmS3SaveState.inf
MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableSmm/FirmwarePerformanceSmm.inf
Thanks,
Andrew Fish
Thanks
Feng
From: Olivier Martin [mailto:[email protected]]
Sent: Thursday, December 11, 2014 19:16
To: Tian, Feng
Cc: [email protected]<mailto:[email protected]>
Subject: [PATCH] MdeModulePkg/DxeCore: Fixed compiler error 'enumerated type
mixed with another type'
Dear MdeMdoulePkg maintainer,
Please find the attached patch that fix a ARM Toolchain warning/error.
ARM Toolchain raises a warning/error when an integer is used instead of a enum
value.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin
<[email protected]<mailto:[email protected]>>
Regards,
Olivier
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk_______________________________________________
edk2-devel mailing list
[email protected]<mailto:[email protected]>
https://lists.sourceforge.net/lists/listinfo/edk2-devel
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
