On 12/16/14 13:22, Olivier Martin wrote:
> I know you are not the author of the original patch, but our CI complains
> with the following coding style errors:
>
> ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/IntelBdsPlat
> form.c:67 - missing space before open parenthesis - if (EFI_ERROR(Status))
> {
> ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/IntelBdsPlat
> form.c:75 - missing space before open parenthesis -
> ASSERT_EFI_ERROR(Status);
> ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/IntelBdsPlat
> form.c:86 - missing space before open parenthesis - DevicePathStr =
> (CHAR16*)AllocateCopyPool ((NextDevicePathStr - DefaultConsolePaths + 1) *
> sizeof(CHAR16), DefaultConsolePaths);
> ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/IntelBdsPlat
> form.c:95 - missing space before open parenthesis -
> ASSERT(DevicePathInstance != NULL);
> ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/IntelBdsPlat
> form.c:119 - missing space before open parenthesis - if
> (!EFI_ERROR(Status)) {
> ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/IntelBdsPlat
> form.c:145 - missing space before open parenthesis - DEBUG_CODE_BEGIN();
> ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/IntelBdsPlat
> form.c:146 - missing space before open parenthesis - if
> (EFI_ERROR(Status)) {
> ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/IntelBdsPlat
> form.c:152 - missing space before open parenthesis - Status =
> gBS->LocateProtocol(&gEfiDevicePathToTextProtocolGuid, NULL, (VOID
> **)&DevicePathToTextProtocol);
> ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/IntelBdsPlat
> form.c:153 - missing space before open parenthesis - if
> (!EFI_ERROR(Status)) {
> ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/IntelBdsPlat
> form.c:156 - missing space after comma or semicolon -
> DEBUG((EFI_D_ERROR,"Fail to start the console with the Device Path '%s'.
> (Error '%r')\n", DevicePathTxt, Status));
> ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/IntelBdsPlat
> form.c:156 - missing space before open parenthesis -
> DEBUG((EFI_D_ERROR,"Fail to start the console with the Device Path '%s'.
> (Error '%r')\n", DevicePathTxt, Status));
> ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/IntelBdsPlat
> form.c:161 - missing space before open parenthesis - DEBUG_CODE_END();
> ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/IntelBdsPlat
> form.c:165 - missing space before open parenthesis - if
> (!EFI_ERROR(Status) && (*Interface == NULL)) {
> ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/IntelBdsPlat
> form.c:178 - missing space before open parenthesis - if
> (!EFI_ERROR(Status)) {
> ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/IntelBdsPlat
> form.c:216 - missing space before open parenthesis - Status =
> GetConsoleDevicePathFromVariable (L"ConOut",
> (CHAR16*)PcdGetPtr(PcdDefaultConOutPaths), &ConOutDevicePaths);
> ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/IntelBdsPlat
> form.c:218 - missing space before open parenthesis - Status =
> GetConsoleDevicePathFromVariable (L"ConIn",
> (CHAR16*)PcdGetPtr(PcdDefaultConInPaths), &ConInDevicePaths);
> ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/IntelBdsPlat
> form.c:220 - missing space before open parenthesis - Status =
> GetConsoleDevicePathFromVariable (L"ErrOut",
> (CHAR16*)PcdGetPtr(PcdDefaultConOutPaths), &ConErrDevicePaths);
> ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/IntelBdsPlat
> form.c:229 - missing space before open parenthesis - if
> (EFI_ERROR(Status)) {
I am cleaning up these errors, but I should really be highly decorated
for unwrapping your error log first...
Thanks
Laszlo
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
