Thanks Bruce.
Yes, the 0.73 binary modules are too old.  Newer version of binary has not been 
released yet. But at this point, your fixing the build failure is a great first 
step.
I am OK with this patch, except one minor comment: The same change should also 
be applied to PlatformPkgIA32.dsc.  (“Build_IFWI /IA32 MNW2 Release” is the 
build command for building 32-bit tip)

Thanks,
David | SSG BIOS

From: Bruce Cran [mailto:[email protected]]
Sent: Friday, January 23, 2015 12:08 AM
To: Wei, David
Cc: He, Tim; [email protected]; Wu, Mike
Subject: Re: [edk2] [PATCH] Fix the Windows MNW2/Vlv2TbltDevicePkg build

If I can get the board booting, I'll run the SCT 2.4B RC to verify 
functionality. However, at the moment with both VS2010 and VS2012 builds from 
https://svn.code.sf.net/p/edk2/code/trunk/edk2@16634 fail to boot with the 
assertion failure:

------------------------ VLV SSA Platform Policy dump Begin ---------------
Graphics Configuration:
 GttSize : 2 MB
 IgdDvmt50PreAlloc : 2
 PrimaryDisplay : 0
 ApertureSize : 2
 Turbo Enable : 1

------------------------ VLV SSA Platform Policy dump END -----------------
ProgramEcBase Done....

ASSERT_EFI_ERROR (Status = Buffer Too Small)

PEI_ASSERT!: 
m:\Vlv2DeviceRefCodePkg\ValleyView2Soc\NorthCluster\VlvInit\Pei\VlvInitPeim.c 
(107): !EFI_ERROR (Status)

Of course I don't have access to any of the binary modules newer than 0.73 from 
http://firmware.intel.com/projects/minnowboard-max, so maybe that's causing a 
problem?

--
Bruce

On Sun, Jan 18, 2015 at 10:16 PM, Wei, David 
<[email protected]<mailto:[email protected]>> wrote:
Could you update check-in log by including what test have you done with the 
final 8MB flash image?

Thanks,
David | SSG BIOS

-----Original Message-----
From: Bruce Cran [mailto:[email protected]<mailto:[email protected]>]
Sent: Friday, January 16, 2015 12:16 AM
To: [email protected]<mailto:[email protected]>
Cc: He, Tim; Wei, David
Subject: Re: [edk2] [PATCH] Fix the Windows MNW2/Vlv2TbltDevicePkg build

On 1/15/2015 9:02 AM, Bruce Cran wrote:
> Fix the Windows MNW2 build by updating the library paths and adding
> support for VS2012 and VS2013.

Sorry, the bld_vlv.bat change had a couple of missing parentheses, resulting in 
a build error. The following change fixes it:

diff --git a/Vlv2TbltDevicePkg/bld_vlv.bat b/Vlv2TbltDevicePkg/bld_vlv.bat 
index a84d01b..8434654 100644
--- a/Vlv2TbltDevicePkg/bld_vlv.bat
+++ b/Vlv2TbltDevicePkg/bld_vlv.bat
@@ -148,12 +148,14 @@ if defined VS90COMNTOOLS (
      set TOOL_CHAIN_TAG=VS2012
    ) else (
      set TOOL_CHAIN_TAG=VS2012x86
+  )^M
  ) else if defined VS120COMNTOOLS (
    if not defined VSINSTALLDIR call "%VS120COMNTOOLS%\vsvars32.bat"
    if /I "%VS120COMNTOOLS%" == "C:\Program Files\Microsoft Visual Studio 
12.0\Common7\Tools\" (
      set TOOL_CHAIN_TAG=VS2013
    ) else (
      set TOOL_CHAIN_TAG=VS2013x86
+  )^M
  ) else (
    echo  --ERROR: VS2008/VS2010/VS2012/VS2013 not installed correctly.
VS90COMNTOOLS/VS100COMNTOOLS/VS110COMNTOOLS/VS120COMNTOOLS not define
    echo.


Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bruce Cran <[email protected]<mailto:[email protected]>>

--
Bruce Cran

------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to