On 01/23/15 19:24, Stefano Stabellini wrote: > On Fri, 23 Jan 2015, Ard Biesheuvel wrote: >> For future ARM/AArch64 support in the XenBus code, move the implementation >> of hypercall invocation to a dedicated library. The use of a library rather >> than just an arch specific source in XenBusDxe.inf allows us to move the >> constructor dependency on the gXenInfoGuid HOB to the library implementation. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ard Biesheuvel <[email protected]> > > Although it looks vaguely OK, I think it would be much more readable if > you broke this patch down, separating out the code movements from the > changes to the interface (like dropping the XENBUS_DEVICE* parameter).
If that's possible, then I second the motion. Thanks Laszlo ------------------------------------------------------------------------------ New Year. New Location. New Benefits. New Data Center in Ashburn, VA. GigeNET is offering a free month of service with a new server in Ashburn. Choose from 2 high performing configs, both with 100TB of bandwidth. Higher redundancy.Lower latency.Increased capacity.Completely compliant. http://p.sf.net/sfu/gigenet _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
