On 27 January 2015 at 12:44, Julien Grall <[email protected]> wrote: > Hi Ard, > > I don't know how works platform description in tianocore, but I have few > questions about some file includes in the build. > > On 26/01/15 19:03, Ard Biesheuvel wrote: >> + # >> + # ARM PrimeCell >> + # >> + >> + ## PL011 - Serial Terminal >> + gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|38400 > > We don't use PL011, so maybe it's not necessary. >
Correct. >> + # >> + # ARM OS Loader >> + # >> + gArmPlatformTokenSpaceGuid.PcdDefaultBootDescription|L"Linux (EFI stub) >> on virtio31:hd0:part0" > > The description look wrong here. > >> + >> gArmPlatformTokenSpaceGuid.PcdDefaultBootDevicePath|L"VenHw(837DCA9E-E874-4D82-B29A-23FE0E23D1E2,003E000A00000000)/HD(1,MBR,0x00000000,0x3F,0x19FC0)/Image" >> + gArmPlatformTokenSpaceGuid.PcdDefaultBootArgument|"root=/dev/vda2 >> console=ttyAMA0 earlycon uefi_debug" > > This wouldn't not work by default on ARM guest. > > root=/dev/xvda2 (assuming we want to use partition 2) > console=hvc0 > This is completely bogus, and just copy-paste from the QEMU version. I will correct this in the next version >> + >> + ## PL031 RealTimeClock >> + gArmPlatformTokenSpaceGuid.PcdPL031RtcBase|0x0 > > Will we use it on Xen guest? > Nope > [..] > >> + # >> + # Platform Driver >> + # >> + ArmPlatformPkg/ArmVirtualizationPkg/VirtFdtDxe/VirtFdtDxe.inf >> + OvmfPkg/VirtioBlkDxe/VirtioBlk.inf >> + OvmfPkg/VirtioScsiDxe/VirtioScsi.inf >> + OvmfPkg/VirtioNetDxe/VirtioNet.inf > > Doesn't see useful as we won't support Virtio for now. > Correct. > [..] > >> diff --git a/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationXen.fdf >> b/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationXen.fdf >> new file mode 100644 >> index 000000000000..4676a7b2b29f >> --- /dev/null >> +++ b/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationXen.fdf > > [..] > >> + # >> + # Multiple Console IO support >> + # >> + INF MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf >> + INF MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf >> + INF >> MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf > > We don't have graphic support for Xen guest. > OK >> + INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf >> + INF EmbeddedPkg/SerialDxe/SerialDxe.inf >> + >> + INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf >> + INF ArmPkg/Drivers/TimerDxe/TimerDxe.inf >> + INF MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf >> + >> + # >> + # FAT filesystem + GPT/MBR partitioning >> + # >> + INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf >> + INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf >> + INF FatBinPkg/EnhancedFatDxe/Fat.inf >> + INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> + >> + # >> + # Platform Driver >> + # >> + INF OvmfPkg/VirtioBlkDxe/VirtioBlk.inf >> + INF OvmfPkg/VirtioNetDxe/VirtioNet.inf >> + INF OvmfPkg/VirtioScsiDxe/VirtioScsi.inf > > Ditto for virtio. > > [..] > >> + # >> + # Networking stack >> + # >> + INF MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf >> + INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf >> + INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf >> + INF MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxe.inf >> + INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf >> + INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf >> + INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf >> + INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf >> + INF MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf >> + INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf >> + INF MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf >> + INF MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf > > AFAIK, we don't have PV network for Xen in tianocore. Maybe we could > drop the networking stack. > Ah yes, we only have PV block devices. Yes, this can be removed then. -- Ard. ------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
