On 02/01/15 15:20, Laszlo Ersek wrote: > Version 2 of > <http://thread.gmane.org/gmane.comp.bios.tianocore.devel/12158>. > > In v1 we reached an impasse with Jordan; see the sub-thread at > <http://thread.gmane.org/gmane.comp.bios.tianocore.devel/12158/focus=12282>. > Jordan then offered on IRC to reimplement the splitting of > "OvmfPkg/AcpiPlatformDxe/Qemu.c" for v2, which I gladly accepted, saying > that this was a bullet-proof way to pass his review :) > > I still believe that my splitting resulted in a "more accessible" source > tree... The counts of new files are comparable. I preferred the > separation of the loader stuff into a new library and subdirectory, and > disliked multiple INF files in the same directory. Jordan had the polar > opposite preferences. :) > > I do recognize that Jordan's solution works great (I tested it), and I'm > impressed by the Depex.<arch> trick that expresses the conditional > dependency on the completion of the PCI enumeration. So, any remaining > grumbles I might have shall not get in the way of this feature, and (of > course) let me say thanks to Jordan for taking the time to illustrate > his idea by writing the code. :) > > The series is fully reviewed. I added my R-b to Jordan's patches at the > front, and kept Olivier's R-b from v1 at the back > <http://thread.gmane.org/gmane.comp.bios.tianocore.devel/12158/focus=12168>. > I'll let the series sit for one or two days on edk2-devel, and unless > someone objects, I'll push it. > > I formatted the series again with inter-file copy detection. > > Thanks Jordan! ;) > Laszlo > > Jordan Justen (2): > OvmfPkg/AcpiPlatformDxe: Split QEMU fw-cfg into a new file > OvmfPkg/AcpiPlatformDxe: Add QEMU fw-cfg only driver > > Laszlo Ersek (1): > ArmVirtualizationPkg: add simple ACPI Platform Driver to the QEMU > platform > > OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf > | 1 + > OvmfPkg/AcpiPlatformDxe/{AcpiPlatformDxe.inf => > QemuFwCfgAcpiPlatformDxe.inf} | 47 ++--- > OvmfPkg/AcpiPlatformDxe/Qemu.c > | 660 ---------------------------------------------------------------- > OvmfPkg/AcpiPlatformDxe/{Qemu.c => QemuFwCfgAcpi.c} > | 495 +----------------------------------------------- > OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatform.c > | 52 +++++ > ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualization.dsc.inc > | 1 + > ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationQemu.dsc > | 6 + > ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationQemu.fdf > | 6 + > 8 files changed, 82 insertions(+), 1186 deletions(-) > copy OvmfPkg/AcpiPlatformDxe/{AcpiPlatformDxe.inf => > QemuFwCfgAcpiPlatformDxe.inf} (51%) > copy OvmfPkg/AcpiPlatformDxe/{Qemu.c => QemuFwCfgAcpi.c} (60%) > create mode 100644 OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatform.c >
Public branch: <https://github.com/lersek/edk2/commits/armvirt_acpi_v2>. ------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
