On 02/02/15 14:29, Gao, Liming wrote: > Laszlo: > Thanks for your comments. > 1) BIT28 should be BIT31. > 2) New PCD PcdFixedDebugPrintErrorLevel value should be mask value of all > BITs so that it doesn't bring impact for current platform. If platform wants > to use this feature, platform can configure its value to new one in their DSC > file. > > I make new patch for this update. Please help review it. > --- > MdePkg/MdePkg.dec | 6 +++--- > MdePkg/MdePkg.uni | Bin 66564 -> 66564 bytes > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > index 3f3485d..1f9b54d 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -1628,10 +1628,10 @@ > # BIT20 - Global Coherency Database changes message.<BR> > # BIT21 - Memory range cachability changes message.<BR> > # BIT22 - Detailed debug message.<BR> > - # BIT28 - Error message.<BR> > + # BIT31 - Error message.<BR> > # @Prompt Fixed Debug Message Print Level. > # @Expression 0x80000002 | > (gEfiMdePkgTokenSpaceGuid.PcdFixedDebugPrintErrorLevel & 0x7F84AA00) == 0 > - > gEfiMdePkgTokenSpaceGuid.PcdFixedDebugPrintErrorLevel|0x80000000|UINT32|0x30001016 > + > gEfiMdePkgTokenSpaceGuid.PcdFixedDebugPrintErrorLevel|0x807B55FF|UINT32|0x30001016 >
I think this is a great idea, but I propose the value 0xF07FFFFF instead (or even 0xFFFFFFFF). The value 0xF07FFFFF comes from OR-ing together all the PcdDebugPrintErrorLevel values that I collected in my previous email (in the attached file "PcdDebugPrintErrorLevel.txt"). And the alternative, 0xFFFFFFFF, would *guarantee* that no DSC-specific setting is regressed, even if it uses some private bits in the mask (for example, BIT23). What do you think? Thanks! Laszlo ------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
