On 02/17/15 20:15, Laszlo Ersek wrote: > On 02/17/15 18:14, Jordan Justen wrote: >> In OvmfPkg/AcpiPlatformDxe, we now look at the setting of >> PcdPciDisableBusEnumeration. If enumeration is enabled, then we wait >> for a callback on the gEfiPciEnumerationCompleteProtocolGuid protocol >> before installing the ACPI tables. Otherwise, we install the ACPI >> tables immediately. >> >> https://github.com/jljusten/edk2.git acpi-pci-pcd >> >> Jordan Justen (5): >> OvmfPkg/AcpiPlatformDxe: FindAcpiTablesInFv => InstallOvmfFvTables >> OvmfPkg/AcpiPlatformDxe: InstallAllQemuLinkedTables => >> InstallQemuFwCfgTables >> ArmVirtualizationPkg: Set PcdPciDisableBusEnumeration to TRUE >> OvmfPkg/AcpiPlatformDxe: Conditional callback for >> PciEnumerationComplete >> OvmfPkg/AcpiPlatformDxe: Remove PciEnumerationComplete depex >> >> .../ArmVirtualizationPkg/ArmVirtualizationQemu.dsc | 4 + >> OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c | 95 >> ++++++++++++++++++---- >> OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h | 5 +- >> OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 4 +- >> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 82 +++++++++++++++---- >> .../AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf | 7 +- >> 6 files changed, 160 insertions(+), 37 deletions(-) >> > > The approach taken in this patchset is one of the first ideas I had > while pondering the issue over the weekend. I didn't dare suggesting it, > lest I be crucified for trying to repurpose PcdPciDisableBusEnumeration > (because it now has dual consumption).
Some clarification / correction: I didn't shy away from using this PCD in: [edk2] [PATCH] OvmfPkg: AcpiPlatformDxe: PCI enumeration may be disabled <http://thread.gmane.org/gmane.comp.bios.tianocore.devel/12608> but that patch doesn't count as "repurposing the PCD". "Repurposing the PCD" will be when I set it to TRUE in VirtFdtDxe, on ARM, when the PCI host bridge will be absent, because I'll know that PciBusDxe won't even Start(). So, it's great that you're fine with that, thanks! Laszlo > I'm *delighted* to see this idea > coming from you, because now I won't have to argue for it! :) > > So, I'll review the patches in a minute. > > Thanks! > Laszlo > > ------------------------------------------------------------------------------ > Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server > from Actuate! Instantly Supercharge Your Business Reports and Dashboards > with Interactivity, Sharing, Native Excel Exports, App Integration & more > Get technology previously reserved for billion-dollar corporations, FREE > http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/edk2-devel > ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
