On 02/23/15 16:28, Olivier Martin wrote:
> Actually for this one, would you mind to replace the 'ASSERT_EFI_ERROR
> (Status);' (the one after gDS->AddMemorySpace() and the one after
> gDS->SetMemorySpaceAttributes()) by:
>
> if (EFI_ERROR (Status)) {
> return Status;
> }
>
> ... or anything similar. It is mainly if the memory map changes between
> DEBUG and RELEASE for various reasons, it would be nice to prevent a
> crash in RELEASE.
>
> Except this comment:
>
> Reviewed-By: Olivier Martin <[email protected]>
Many thanks to everyone for the repeated and quick reviews. I committed
the series (with the above changes) as revisions 16889 through 16916,
inclusive.
Laszlo
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel