On 03/02/15 09:35, Ard Biesheuvel wrote:
> On 27 February 2015 at 19:55, Laszlo Ersek <ler...@redhat.com> wrote:
>> This enables -D DEBUG_PRINT_ERROR_LEVEL=0x8040004F style command line
>> options.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Laszlo Ersek <ler...@redhat.com>
>> ---
>>  ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualization.dsc.inc | 8 +++++---
>>  ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationQemu.dsc | 4 ++--
>>  2 files changed, 7 insertions(+), 5 deletions(-)
>>
>> diff --git a/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualization.dsc.inc 
>> b/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualization.dsc.inc
>> index 1a82762..69a07c5 100644
>> --- a/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualization.dsc.inc
>> +++ b/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualization.dsc.inc
>> @@ -275,8 +275,8 @@
>>    #  DEBUG_FS        0x00000008  // EFI File system
>>    #  DEBUG_POOL      0x00000010  // Alloc & Free's
>>    #  DEBUG_PAGE      0x00000020  // Alloc & Free's
>> -  #  DEBUG_INFO      0x00000040  // Verbose
>> -  #  DEBUG_DISPATCH  0x00000080  // PEI/DXE Dispatchers
>> +  #  DEBUG_INFO      0x00000040  // Informational debug messages
>> +  #  DEBUG_DISPATCH  0x00000080  // PEI/DXE/SMM Dispatchers
>>    #  DEBUG_VARIABLE  0x00000100  // Variable
>>    #  DEBUG_BM        0x00000400  // Boot Manager
>>    #  DEBUG_BLKIO     0x00001000  // BlkIo Driver
>> @@ -286,8 +286,10 @@
>>    #  DEBUG_EVENT     0x00080000  // Event messages
>>    #  DEBUG_GCD       0x00100000  // Global Coherency Database changes
>>    #  DEBUG_CACHE     0x00200000  // Memory range cachability changes
>> +  #  DEBUG_VERBOSE   0x00400000  // Detailed debug messages that may
>> +  #                              // significantly impact boot performance
>>    #  DEBUG_ERROR     0x80000000  // Error
>> -  # gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000000F
>> +  
>> gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|$(DEBUG_PRINT_ERROR_LEVEL)
>>
>>    gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x07
>>
>> diff --git a/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationQemu.dsc 
>> b/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationQemu.dsc
>> index 9a7ebe2..ad53937 100644
>> --- a/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationQemu.dsc
>> +++ b/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationQemu.dsc
>> @@ -28,6 +28,8 @@
>>    SKUID_IDENTIFIER               = DEFAULT
>>    FLASH_DEFINITION               = 
>> ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationQemu.fdf
>>
>> +  DEFINE DEBUG_PRINT_ERROR_LEVEL = 0x8000004F
>> +
> 
> Is it possible to define this in the .dsc.inc if it is not defined
> already? I guess things break otherwise if the define is missing from
> the .dsc

I wrote and posted this patchset before merging your Xen series.

Do you want me to respin patch #4 so that it updates
"ArmVirtualizationXen.dsc" too?

Thanks
Laszlo

------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to