On 03/02/15 16:04, Leif Lindholm wrote: > On 02/03/15 13:54, Laszlo Ersek wrote: >> On 03/02/15 14:18, Leif Lindholm wrote: >>> On Mon, Mar 02, 2015 at 01:03:53PM +0100, Laszlo Ersek wrote: >>>> This enables -D DEBUG_PRINT_ERROR_LEVEL=0x8040004F style command line >>>> options. >>> >>> Should also mention that it clarifies some comments. >> >> Will do. >> >>>> Contributed-under: TianoCore Contribution Agreement 1.0 >>>> Signed-off-by: Laszlo Ersek <ler...@redhat.com> >>>> --- >>>> >>>> Notes: >>>> v2: >>>> - move DEBUG_PRINT_ERROR_LEVEL default to >>>> ArmVirtualization.dsc.inc so >>>> it affects both ArmVirtualizationQemu.dsc and >>>> ArmVirtualizationXen.dsc >>>> [Ard] >>>> >>>> ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualization.dsc.inc | 11 >>>> ++++++++--- >>>> ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationQemu.dsc | 2 -- >>>> ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationXen.dsc | 2 -- >>>> 3 files changed, 8 insertions(+), 7 deletions(-) >>>> >>>> diff --git >>>> a/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualization.dsc.inc >>>> b/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualization.dsc.inc >>>> index 565f243..4e30e9f 100644 >>>> --- a/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualization.dsc.inc >>>> +++ b/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualization.dsc.inc >>>> @@ -12,6 +12,9 @@ >>>> # >>>> # >>>> >>>> +[Defines] >>>> + DEFINE DEBUG_PRINT_ERROR_LEVEL = 0x8000004F >>>> + >>>> [LibraryClasses.common] >>>> !if $(TARGET) == RELEASE >>>> DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf >>>> @@ -277,8 +280,8 @@ >>>> # DEBUG_FS 0x00000008 // EFI File system >>>> # DEBUG_POOL 0x00000010 // Alloc & Free's >>>> # DEBUG_PAGE 0x00000020 // Alloc & Free's >>>> - # DEBUG_INFO 0x00000040 // Verbose >>>> - # DEBUG_DISPATCH 0x00000080 // PEI/DXE Dispatchers >>>> + # DEBUG_INFO 0x00000040 // Informational debug messages >>>> + # DEBUG_DISPATCH 0x00000080 // PEI/DXE/SMM Dispatchers >>> >>> SMM? >> >> Not relevant for this platform, but this is how the bits are explained >> in "MdePkg/Include/Library/DebugLib.h". > > Ok - mental note to change the core version to something less > architecture-specific in future. > >> If I mention the comment fixups in the commit message, and reference >> "MdePkg/Include/Library/DebugLib.h" too, can I add your R-b? (With the >> ARM email address.) > > That works for me. > > Reviewed-by: Leif Lindholm <leif.lindh...@arm.com>
Thank you. Committed to SVN as 16983..16986. Cheers Laszlo ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
