Good question.
Code has been public in a zip on http://firmware.intel.com  for some time.
We have received feedback on that zip from coreboot community & others, 
including Stefan, that helped inform moving it to live SCM on tianocore so that 
it can be evolved with the community.
Wiki at 
https://github.com/tianocore/tianocore.github.io/wiki/Coreboot_UEFI_payload, too
Vincent
-----Original Message-----
From: Jordan Justen [mailto:jljus...@gmail.com] 
Sent: Tuesday, March 31, 2015 11:40 AM
To: edk2-devel@lists.sourceforge.net; Ma, Maurice; Agyeman, Prince
Cc: Patrick Georgi
Subject: Re: [edk2] edk2[17084] Pkg-Module: CorebootModulePkg

Why didn't this get posted for review before being committed?

I wonder if Patrick might have had some thoughts from having worked on:
https://github.com/pgeorgi/edk2/tree/coreboot-pkg

On Mon, Mar 30, 2015 at 6:06 PM,  <mauric...@users.sourceforge.net> wrote:
> Revision: 17084
>           http://sourceforge.net/p/edk2/code/17084
> Author:   mauricema
> Date:     2015-03-31 01:06:23 +0000 (Tue, 31 Mar 2015)
> Log Message:
> -----------
> Pkg-Module: CorebootModulePkg

This probably should have been:
CorebootModulePkg: Add coreboot payload module

'Pkg-Module' in the commit template is intended to be replaced by the package 
and module that the patch is related to.

I'm wondering if there might have been an opportunity to commit this package in 
pieces rather than in 1 big commit.

Will you be sending a patch to edk2-devel to update the Maintainers.txt?

-Jordan

> Initial coreboot UEFI payload code check in. It provides UEFI services on top 
> of coreboot that allows UEFI OS boot.
> CorebootModulePkg is the source code package of coreboot support modules that 
> will be used to parse the coreboot tables and report memory/io resources.
>
> It supports the following features:
>   - Support Unified Extensible Firmware Interface (UEFI) specification 2.4.
>   - Support Platform Initialization(PI) specification 1.3.
>   - Support execution as a coreboot payload.
>   - Support USB 3.0
>   - Support SATA/ATA devices.
>   - Support EFI aware OS boot.
>
> The following features are not supported currently and have not been 
> validated:
>   - GCC Tool Chains
>   - SMM Execution Environment
>   - Security Boot
>
> It was tested on a Intel Bay Trail CRB platform.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Maurice Ma <maurice...@intel.com>
> Reviewed-by: Prince Agyeman <prince.agye...@intel.com>
>
> Added Paths:
> -----------
>     trunk/edk2/CorebootModulePkg/CbSupportDxe/
>     trunk/edk2/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c
>     trunk/edk2/CorebootModulePkg/CbSupportDxe/CbSupportDxe.h
>     trunk/edk2/CorebootModulePkg/CbSupportDxe/CbSupportDxe.inf
>     trunk/edk2/CorebootModulePkg/CbSupportPei/
>     trunk/edk2/CorebootModulePkg/CbSupportPei/CbSupportPei.c
>     trunk/edk2/CorebootModulePkg/CbSupportPei/CbSupportPei.h
>     trunk/edk2/CorebootModulePkg/CbSupportPei/CbSupportPei.inf
>     trunk/edk2/CorebootModulePkg/CorebootModulePkg.dec
>     trunk/edk2/CorebootModulePkg/Include/
>     trunk/edk2/CorebootModulePkg/Include/Coreboot.h
>     trunk/edk2/CorebootModulePkg/Include/Guid/
>     trunk/edk2/CorebootModulePkg/Include/Guid/AcpiBoardInfoGuid.h
>     trunk/edk2/CorebootModulePkg/Include/Guid/FrameBufferInfoGuid.h
>     trunk/edk2/CorebootModulePkg/Include/Guid/SystemTableInfoGuid.h
>     trunk/edk2/CorebootModulePkg/Include/Library/
>     trunk/edk2/CorebootModulePkg/Include/Library/CbParseLib.h
>     trunk/edk2/CorebootModulePkg/Library/
>     trunk/edk2/CorebootModulePkg/Library/CbParseLib/
>     trunk/edk2/CorebootModulePkg/Library/CbParseLib/CbParseLib.c
>     trunk/edk2/CorebootModulePkg/Library/CbParseLib/CbParseLib.inf
>     trunk/edk2/CorebootModulePkg/SecCore/
>     trunk/edk2/CorebootModulePkg/SecCore/FindPeiCore.c
>     trunk/edk2/CorebootModulePkg/SecCore/Ia32/
>     trunk/edk2/CorebootModulePkg/SecCore/Ia32/SecEntry.S
>     trunk/edk2/CorebootModulePkg/SecCore/Ia32/SecEntry.asm
>     trunk/edk2/CorebootModulePkg/SecCore/Ia32/Stack.S
>     trunk/edk2/CorebootModulePkg/SecCore/Ia32/Stack.asm
>     trunk/edk2/CorebootModulePkg/SecCore/SecCore.inf
>     trunk/edk2/CorebootModulePkg/SecCore/SecMain.c
>     trunk/edk2/CorebootModulePkg/SecCore/SecMain.h

------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored 
by Intel and developed in partnership with Slashdot Media, is your hub for all 
things parallel software development, from weekly thought leadership blogs to 
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to