On 2015-04-05 21:32:54, Scott Duplichan wrote: > Make CbDxeEntryPoint function match the AutoGen.h prototype to avoid gcc > compile fail. The change is only needed for gcc builds because EFIAPI ABI > differs from the default ABI when gcc is used.
No. This change is needed because EFIAPI should be added to all entry point functions. It just happens that certain GCC toolchains are the only ones that can catch this error. I think a better commit message would be: === CorebootModulePkg/CbSupportDxe: Add EFIAPI to CbDxeEntryPoint All image entry point functions must use EFIAPI. Some GCC toolchains will have a build error without this fix. === Reviewed-by: Jordan Justen <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Scott Duplichan <[email protected]> > --- > > Index: CorebootModulePkg/CbSupportDxe/CbSupportDxe.c > =================================================================== > --- CorebootModulePkg/CbSupportDxe/CbSupportDxe.c (revision 17108) > +++ CorebootModulePkg/CbSupportDxe/CbSupportDxe.c (working copy) > @@ -122,6 +122,7 @@ > > **/ > EFI_STATUS > +EFIAPI > CbDxeEntryPoint ( > IN EFI_HANDLE ImageHandle, > IN EFI_SYSTEM_TABLE *SystemTable ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
