Scott: Your patch is good. Reviewed-by: Liming Gao <[email protected]>
Thanks Liming -----Original Message----- From: Scott Duplichan [mailto:[email protected]] Sent: Monday, April 06, 2015 12:25 PM To: [email protected]; Ma, Maurice; Agyeman, Prince; Gao, Liming Subject: [Patch 9/16] MdePkg: Fix build fail when DDK3790 tool chain is used Modify the preprocessor check for variadic macro support. The existing check assumes all Microsoft compilers with major version of 14 and greater support variadic macros. This is almost correct. An exception is the X64 compiler from DDK3790. This compiler has version 14.00.40310.41, yet does not support variadic macros. Both VS2005 compilers have version number 14.00.50727.762 and do support variadic macros. For simplicity, this change suppresses the use of variadic macros for all Microsoft compilers with version 14 or smaller. If the variadic macro support needs to be restored for VS2005, that could be done using new logic invloving _MSC_FULL_VER. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Scott Duplichan <[email protected]> --- Index: MdePkg/Include/Library/DebugLib.h =================================================================== --- MdePkg/Include/Library/DebugLib.h (revision 17108) +++ MdePkg/Include/Library/DebugLib.h (working copy) @@ -260,7 +260,7 @@ **/ -#if !defined(MDE_CPU_EBC) && (!defined (_MSC_VER) || _MSC_VER >= 1400) +#if !defined(MDE_CPU_EBC) && (!defined (_MSC_VER) || _MSC_VER > 1400) #define _DEBUG_PRINT(PrintLevel, ...) \ do { \ if (DebugPrintLevelEnabled (PrintLevel)) { \ ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
