The patch looks good to me. Reviewed-by: Maurice Ma <[email protected]>
Thanks Maurice -----Original Message----- From: Scott Duplichan [mailto:[email protected]] Sent: Sunday, April 05, 2015 9:15 PM To: [email protected]; Ma, Maurice; Agyeman, Prince Subject: [Patch 2/16] CorebootModulePkg: Fix build failure with 32-bit NOOPT target Fix build failure with 32-bit NOOPT target by replacing direct shift of 64-bit integer with a function call. Otherwise Microsoft tool chains will generate a call to function __allshl and fail to link. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Scott Duplichan <[email protected]> --- Index: CorebootModulePkg/Library/CbParseLib/CbParseLib.c =================================================================== --- CorebootModulePkg/Library/CbParseLib/CbParseLib.c (revision 17108) +++ CorebootModulePkg/Library/CbParseLib/CbParseLib.c (working copy) @@ -28,7 +28,7 @@ static UINT64 cb_unpack64(struct cbuint64 val) { - return (((UINT64) val.hi) << 32) | val.lo; + return LShiftU64 (val.hi, 32) | val.lo; } static const char *cb_mb_vendor_string(const struct cb_mainboard *cbm) ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
