Hi, Scott, Can we change the " void **" to "VOID **" in this patch ?
Reviewed-by: Maurice Ma <[email protected]> Thanks Maurice -----Original Message----- From: Scott Duplichan [mailto:[email protected]] Sent: Sunday, April 05, 2015 9:19 PM To: [email protected]; Ma, Maurice; Agyeman, Prince Subject: [Patch 4/16] CorebootModulePkg: Change CbParseAcpiTable prototype to avoid gcc fail Use of void** as a generic pointer to pointer is a Microsoft extension to the C language and is not supported by gcc. Without this change, gcc compile fails with error: passing argument 1 of 'CbParseAcpiTable' from incompatible pointer type note: expected 'void **' but argument is of type 'struct EFI_ACPI_3_0_ROOT_SYSTEM_DESCRIPTION_POINTER **' Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Scott Duplichan <[email protected]> --- Index: CorebootModulePkg/Include/Library/CbParseLib.h =================================================================== --- CorebootModulePkg/Include/Library/CbParseLib.h (revision 17108) +++ CorebootModulePkg/Include/Library/CbParseLib.h (working copy) @@ -63,7 +63,7 @@ **/ RETURN_STATUS CbParseAcpiTable ( - IN VOID** pMemTable, + IN VOID* pMemTable, IN UINT32* pMemTableSize ); Index: CorebootModulePkg/Library/CbParseLib/CbParseLib.c =================================================================== --- CorebootModulePkg/Library/CbParseLib/CbParseLib.c (revision 17108) +++ CorebootModulePkg/Library/CbParseLib/CbParseLib.c (working copy) @@ -293,11 +293,11 @@ **/ RETURN_STATUS CbParseAcpiTable ( - IN VOID** pMemTable, + IN VOID* pMemTable, IN UINT32* pMemTableSize ) { - return CbParseCbMemTable (SIGNATURE_32 ('I', 'P', 'C', 'A'), pMemTable, pMemTableSize); + return CbParseCbMemTable (SIGNATURE_32 ('I', 'P', 'C', 'A'), (void **)pMemTable, pMemTableSize); } /** ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
