The patch looks good to me. Reviewed-by: Maurice Ma <[email protected]>
Thanks Maurice -----Original Message----- From: Scott Duplichan [mailto:[email protected]] Sent: Sunday, April 05, 2015 9:20 PM To: [email protected]; Ma, Maurice; Agyeman, Prince Subject: [Patch 5/16] CorebootModulePkg: Add 'll' suffix to avoid gcc 4.4 compile fail Add ll siffix to 64-bit constants, otherwise gcc44 reports error: integer constant is too large for 'long' type Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Scott Duplichan <[email protected]> --- Index: CorebootModulePkg/CbSupportPei/CbSupportPei.c =================================================================== --- CorebootModulePkg/CbSupportPei/CbSupportPei.c (revision 17108) +++ CorebootModulePkg/CbSupportPei/CbSupportPei.c (working copy) @@ -238,7 +238,7 @@ EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE | EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE ), - (EFI_PHYSICAL_ADDRESS)(0x100000000), + (EFI_PHYSICAL_ADDRESS)(0x100000000ll), HighMemorySize ); } ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
