On 04/08/15 13:43, Ard Biesheuvel wrote: > On 8 April 2015 at 13:38, Laszlo Ersek <ler...@redhat.com> wrote: >> On 04/08/15 13:33, Ard Biesheuvel wrote: >>> On 8 April 2015 at 13:13, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: >>>> On 8 April 2015 at 13:12, Olivier Martin <olivier.mar...@arm.com> wrote: >>>>> Is the reason why it does not work is dependency issue on other PEIM >>>>> library? >>>> >>>> MODULE_TYPE must be either 'SEC' or 'PEIM' and not both. If we are >>>> going to use the library in modules of both flavors, it would be >>>> cleaner just to use BASE >>>> >>> >>> Actually, looking at it again, shouldn't it just be a PEIM module type? >>> I don't think any modules depend on MemoryInitPeiLib at all, let alone >>> any SEC modules. >> >> In a library instance INF file, there are two things to consider, >> MODULE_TYPE and the client module type list in LIBRARY_CLASS. >> >> I understand the restriction list in LIBRARY_CLASS. I never understood >> what MODULE_TYPE meant for a library instance. The INF file >> specification doesn't document it either -- if I remember correctly, I >> checked, and came up empty. >> > > Actually, it appears to be optional, or at least, everything still > builds fine after I remove it. > > I will change it to 'BASE' instead, which also builds fine. Should I > add the 'SEC PEIM' restriction? It is responsible for setting up the > page tables and enabling the MMU etc so you wouldn't be able to use it > elsewhere anyway.
In general I like to be explicit about the restrictions in LIBRARY_CLASS, yes. Whenever people try to use the library instance in a different client module, they are at least forced to skim the library code before relaxing the restriction. Thanks Laszlo ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
