On 2015-04-07 18:13:52, Gao, Liming wrote: > Yes. I have sent the patch to clean up OvmfPkg, Nt32Pkg and DuetPkg.
I think the issue Gabriel was seeing was that LzmaDecompress.h was not added under MdeModulePkg/Include/Guid. Since you kept the old library, there is no immediate need to update these platforms. (Although, I thought we should consider ways to actually 'move' the library, rather than just duplicating it in two packages.) Regarding the other patches: Can you resend them with git send-email? They are not very visible as attachments to a reply to another patch. You can also consider adding Cc's to the commit messages for the package maintainers. This will let git send-email automatically add a Cc to the package maintainers for the patch they should look at. By the way, it seems there are still quite a lot of other references to the old path... git grep IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib -Jordan > -----Original Message----- > From: Olivier Martin [mailto:olivier.mar...@arm.com] > Sent: Tuesday, April 07, 2015 6:36 PM > To: edk2-devel@lists.sourceforge.net > Subject: Re: [edk2] Lzma GUID patch breaks OVMF build > > There were some recent patches about moving LZME from IntelFrameworkModulePkg > to MdeModulePkg. > I was expected them to break few platforms (including ARM platforms). > OvmfPkg (and ARM platforms) should be updated to pick LZMA from MdeModulePkg. > > > -----Original Message----- > From: Gabriel L. Somlo [mailto:gso...@gmail.com] > Sent: 06 April 2015 14:09 > To: edk2-devel@lists.sourceforge.net > Subject: [edk2] Lzma GUID patch breaks OVMF build > > Hi Liming, > > Starting with commit 584ea2c8ef87e06cee9142966620db7a5bd2d344 > ("IntelFrameworkModulePkg: Move LzmaDecompress GUID", a.k.a. > https://svn.code.sf.net/p/edk2/code/trunk/edk2@17110 > 6f19259b-4bc3-4df7-8a09-765794883524), I can no longer build OVMF (on > Linux/X64): > > build -a X64 -t GCC49 -p OvmfPkg/OvmfPkgX64.dsc > > now fails with > > ... > Building ... > /home/somlo/KVM-OSX/SCRATCH/edk2/IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > [X64] > "/usr/bin/gcc" -g -fshort-wchar -fno-strict-aliasing -Wall -Werror > -Wno-array-bounds -ffunction-sections -fdata-sections -c -include AutoGen.h > -DSTRING_ARRAY_NAME=LzmaDecompressLibStrings -m64 -fno-stack-protector > "-DEFIAPI=__attribute__((ms_abi))" > -DNO_BUILTIN_VA_FUNCS -mno-red-zone -Wno-address -mcmodel=large -Wno-address > -Wno-unused-but-set-variable -mno-mmx -mno-sse -o > /home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib/OUTPUT/./LzmaDecompress.obj > -I/home/somlo/KVM-OSX/SCRATCH/edk2/IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/Sdk/C > -I/home/somlo/KVM-OSX/SCRATCH/edk2/IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib > -I/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib/DEBUG > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/X64 > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Include > /home/somlo/KVM-OSX/SCRATCH/edk2/IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaDecompress.c > In file included from > /home/somlo/KVM-OSX/SCRATCH/edk2/IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaDecompress.c:15:0: > /home/somlo/KVM-OSX/SCRATCH/edk2/IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaDecompressLibInternal.h:23:33: > fatal error: Guid/LzmaDecompress.h: No such file or directory #include > <Guid/LzmaDecompress.h> > ^ > compilation terminated. > make: *** > [/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib/OUTPUT/LzmaDecompress.obj] > Error 1 > GNUmakefile:331: recipe for target > '/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib/OUTPUT/LzmaDecompress.obj' > failed > > > build.py... > : error 7000: Failed to execute command > make tbuild > [/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib] > > > build.py... > : error F002: Failed to build module > > /home/somlo/KVM-OSX/SCRATCH/edk2/IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > [X64, GCC49, DEBUG] > > - Failed - > > > Thanks, > --Gabriel > > > > ------------------------------------------------------------------------------ > BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own > process in accordance with the BPMN 2 standard Learn Process modeling best > practices with Bonita BPM through live exercises > http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ > source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel > > > -- IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. > > ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, > Registered in England & Wales, Company No: 2557590 ARM Holdings plc, > Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England > & Wales, Company No: 2548782 > > > ------------------------------------------------------------------------------ > BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own > process in accordance with the BPMN 2 standard Learn Process modeling best > practices with Bonita BPM through live exercises > http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ > source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel > > ------------------------------------------------------------------------------ > BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT > Develop your own process in accordance with the BPMN 2 standard > Learn Process modeling best practices with Bonita BPM through live exercises > http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ > source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
