On 04/15/15 02:57, Zeng, Star wrote: > Laszlo, > > Reviewed-by: Star Zeng <star.z...@intel.com> > > Yes, go ahead to check in the patch, please.
Done, SVN r17179. Thanks for the quick review! Laszlo > Thanks very much. > Star > -----Original Message----- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, April 15, 2015 8:46 AM > To: edk2-devel@lists.sourceforge.net > Cc: Zeng, Star > Subject: [PATCH] MdeModulePkg: PCD/Pei: eliminate unused but set variable > > - SVN r14866: > > MdePkg and MdeModulePkg Pcd: Add the new EFI_GET_PCD_INFO_PROTOCOL and > EFI_GET_PCD_INFO_PPI support for PI 1.2.1 compliance. > > added the "DataBase" local variable to PcdPeimInit(), and both set it and > used it. > > - SVN r14869: > > MdeModulePkg and Nt32Pkg Pcd: Add the new EFI_GET_PCD_INFO_PROTOCOL and > EFI_GET_PCD_INFO_PPI support for PI 1.2.1 compliance. > > changed the PcdPeimInit() function, but "DataBase" remained both set and used. > > - SVN r17173: > > MdeModulePkg Pcd: Check the input SkuId in SetSku() > > changed the function again; and this time "DataBase" became set-but-unused. > It triggers the following build error, when building > ArmVirtualizationQemu.dsc with gcc-4.8: > > MdeModulePkg/Universal/PCD/Pei/Pcd.c:150:21: error: variable 'DataBase' > set but not used [-Werror=unused-but-set-variable] > PEI_PCD_DATABASE *DataBase; > ^ > cc1: all warnings being treated as errors > > Fix the error by removing the DataBase variable, restoring the pre-r14866 > state locally, when the BuildPcdDatabase() function was called, but its > return value was thrown away. > > Cc: Star Zeng <star.z...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > --- > > Notes: > Star, if you deem the patch correct, I'd like to check it in myself. > Thanks! > > MdeModulePkg/Universal/PCD/Pei/Pcd.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/MdeModulePkg/Universal/PCD/Pei/Pcd.c > b/MdeModulePkg/Universal/PCD/Pei/Pcd.c > index e6b1c15..15f1924 100644 > --- a/MdeModulePkg/Universal/PCD/Pei/Pcd.c > +++ b/MdeModulePkg/Universal/PCD/Pei/Pcd.c > @@ -146,10 +146,9 @@ PcdPeimInit ( > IN CONST EFI_PEI_SERVICES **PeiServices > ) > { > - EFI_STATUS Status; > - PEI_PCD_DATABASE *DataBase; > + EFI_STATUS Status; > > - DataBase = BuildPcdDatabase (FileHandle); > + BuildPcdDatabase (FileHandle); > > // > // Install PCD_PPI and EFI_PEI_PCD_PPI. > -- > 1.8.3.1 > ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
