On 2015-04-10 02:14:01, Zeng, Star wrote: > Laszlo, > > Try to update codebase to SVN R17161 for your build failure. Sorry > for the inconvenience.
Star, Bob, why was it committed without giving edk2-devel a chance to review it? The same might be said of 17161, but in the case of a build break, maybe a shortcut is more acceptable. Mike, do you have any thoughts about why this seems to happen so often? Bob, my feedback is that the commit message seems to indicate that this one commit is doing several things. So often that leads to difficulties if issues arise. I'm not sure how long Laszlo spent investigating this, but with 'one big change' like this it can often increase the debug time substantially. -Jordan > -----Original Message----- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, April 10, 2015 4:50 PM > To: edk2-devel list > Cc: Feng, Bob C; Gerd Hoffmann (GMail address) > Subject: [edk2] SVN r17158 seems to have broken the build > > Hi, > > SVN r17158 ("BaseTools/Build: Add SDL support") seems to have broken the > build. > > First, I'd like to use the opportunity to complain about the commit message > -- it does give some hints, but it should be much more detailed. > If there's a design document or Mantis ticket that the change implements, > that document or ticket should be referenced in the commit message, minimally. > > Of course the patch was not submitted for public review either (or at least > as a heads-up). > > Ditto for SVN revisions 17157 and 17159. > > Second, more importantly, the patch changes DATABASE_VERSION to 5 (from 4), > which causes the AutoGen.h files to contain > > > #define PCD_PEI_SERVICE_DRIVER_VERSION 5 > > and this triggers the following error in > "MdeModulePkg/Universal/PCD/Pei/Service.h": > > > // > > // Please make sure the PCD Serivce PEIM Version is consistent with // > > the version of the generated PEIM PCD Database by build tool. > > // > > #define PCD_SERVICE_PEIM_VERSION 4 > > > > // > > // PCD_PEI_SERVICE_DRIVER_VERSION is defined in Autogen.h. > > // > > #if (PCD_SERVICE_PEIM_VERSION != PCD_PEI_SERVICE_DRIVER_VERSION) > > #error "Please make sure the version of PCD PEIM Service and the > > generated PCD PEI Database match." > > #endif > > If the new database version is compatible with the preexistent PCD drivers, > then the patch should have updated "PCD_SERVICE_PEIM_VERSION" > to 5 as well. > > If the new database version is incompatible, then the BaseTools patch should > not have been committed at all, without bringing the driver code up to date > as well. (And those should be two separate patches if possible, forming a > bisectable series -- the driver code update should come first, probably, and > the basetools patch second.) > > So, what's the recommended way to build the tree at this point? > > Thanks > Laszlo ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
