Jordan,

Yes.  I added a PCD that has a PROMPT and HELP strings in MdeModulePkg.uni.

        #string 
STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialRegisterStride_PROMPT  #language 
en-US "Serial Port Register Stride in Bytes"

        #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialRegisterStride_HELP 
 #language en-US "The number of bytes between registers in serial device.  The 
default is 1 byte."

Mike

-----Original Message-----
From: Justen, Jordan L 
Sent: Wednesday, April 15, 2015 12:41 AM
To: Kinney, Michael D; edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [Patch 8/8] MdeModulePkg: SerialPortLib: Add Quark SoC 
compatibility

Was the MdeModulePkg.uni change meant to be included in the patch?

-Jordan

On 2015-04-14 09:50:00, Kinney, Michael D wrote:
>    Please review the attached patch that adds Quark SoC compatibility to the
>    SerialPortLib in the MdeModulePkg.
> 
>     
> 
>    Some EDK II libraries assume capabilities that are not available on Quark
>    SoC.  With these changes, applications and drivers built for IA32 are
>    compatible with Quark SoC.
> 
>    These patches do not modify X64 specific sources or SSE/SSE2 specific
>    sources.
> 
>     
> 
>    Change Summary:
> 
>    ===============
> 
>    1) Remove use of CMOVx from IA32 assembly. This matches compiler flags for
>    all supported C compilers.
> 
>    2) Use CPUID Leaf 01 to detect CPU capabilities for CLFLUSH, Cache Line
>    Size, FXSAVE/FXTSTOR, CR4.DE, and CR4.OSFXR
> 
>    3) Use CPUID Family/Model/Stepping to detect support for
>    MSR_IA32_APIC_BASE_ADDRESS.  Quark SoC does not support this MSR.
> 
>    4) Add stride PCD to MdeModulePkg to support 16550 UARTs with a register
>    stride that is not 1 byte.  Quark SoC uses a stride of 4 bytes.
> 
>     
> 
>    Contributed-under: TianoCore Contribution Agreement 1.0
> 
>    Signed-off by: Michael Kinney <michael.d.kin...@intel.com>
> 
>     
> 
>     
------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to