Hi, Laszlo I have followed your suggestion to split this fix to 3 git patches, The commit subjects are also updated to <74 characters.
I attach them for your review (I sent them out as attachments as I want to reduce the length of mail body. If you prefer to review the git patch in mail body, please let me know, I will follow this way in future review). For your concern about the change in SourceLevelDebug, Usb 3.0 debug capability only supports the IN and OUT bulk endpoints (please refer to Xhci 1.0 section 7.6.3.2). so it's impossible to have other case. Thanks Feng -----Original Message----- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, April 22, 2015 16:16 To: Tian, Feng; Anbazhagan, Baraneedharan Cc: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] XHCI data transfer size On 04/22/15 10:07, Laszlo Ersek wrote: > On 04/22/15 09:05, Tian, Feng wrote: >> Hi, Baranee >> >> Yes, XHCI spec has the same statement for short packet. >> >> Quote from Xhci spec: >> A Short Packet will trigger the generation of a Transfer Event TRB on >> the Event Ring if the Interrupt-on-Short (ISP) or Interrupt On >> Completion(IOC) flags are set in the TRB that the Short Packet was >> detected on. The Completion Code field of the Transfer Event shall be >> set to Short Packet. The Length field of the Transfer Event shall be >> set to the residual number of bytes not written to the Transfer TRBs' >> data buffer. >> >> I attach the final git patch for your review. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Feng Tian <feng.t...@intel.com> > > For the MdeModulePkg patch: > > Reviewed-by: Laszlo Ersek <ler...@redhat.com> > > (I checked the following in the spec: > - 6.4.1.1 Normal TRB > - 6.4.1.2.2 Data Stage TRB > - 6.4.1.3 Isoch TRB > and indeed the TRB Transfer Length field in all of them occupies the > same bits.) > > For the SourceLevelDebugPkg patch: > > There is no explicit check for TRBPtr->Type; we don't verify the type > of the original TRB that the Event TRB points to. Is it safe to assume > that the original TRB was one of the above types, and therefore > TRANSFER_TRB_NORMAL.Length is safe to get its length? In addition, some meta comments (not relating to XHCI): - fixing the typo in the "Lenth" field should be a separate patch - the subject line of each patch should not be longer than 74 characters (without the bracketed [PATCH] part), such as: MdeModulePkg: XhciDxe: rename "Lenth" to "Length" in TRB structs MdeModulePkg: XhciDxe, XhciPei: fix completed xfer length SourceLevelDebugPkg: DebugCommunicationLibUsb3: fix completed xfer length The commit message bodies can elaborate of course (but they should also be wrapped at 74 chars). Thanks Laszlo
0002-MdeModulePkg-XhciDxe-rename-Lenth-to-Length-in-TRB-s.patch
Description: 0002-MdeModulePkg-XhciDxe-rename-Lenth-to-Length-in-TRB-s.patch
0003-MdeModulePkg-fix-completed-xfer-length-in-XhciDxe-an.patch
Description: 0003-MdeModulePkg-fix-completed-xfer-length-in-XhciDxe-an.patch
0001-SourceLevelDebugPkg-DebugCommunicationLibUsb3-fix-co.patch
Description: 0001-SourceLevelDebugPkg-DebugCommunicationLibUsb3-fix-co.patch
------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
