> On Apr 23, 2015, at 11:35 AM, Narinder Dhillon <[email protected]> wrote:
> 
> Hi All,
> 
> It seems that the variable storage driver was written with parallel nor flash 
> in mind. In order to make it work with a SPI-NOR flash device,

It is designed to work with NOR flash. What properties of a parallel NOR vs. 
SPI NOR do you think are in this code? 

> we have had to copy the 
> "MdeModulePkg/Universal/FaultTolerantWriteDxe+Variable" folders to our own 
> package and modify the code.
> 
> Is my understanding correct ? That the variable store feature does not have 
> block flash device support.
> 

It supports NOR Flash. So the code has the NOR like assumption that you can 
program one bit transition direction on a per bit basis, but the opposite bit 
transition requires a block erase. The Fault Tolerant Write is about having a 
back up copy of the block that go erased. Which bit transition (0 to 1 or 1 to 
0) is supported is abstracted in the code.

> Is it okay to upstream a package for our platform with these folders inside 
> it ?
> 

You can do what ever you want in your own packages. IMHO if you want to change 
the way one of the standard drivers work, and you have not intent of getting 
the open source driver changed you should just copy the driver into your own 
package and modify it. 

Thanks,

Andrew Fish

> Thanx,
> 
> Narinder Dhillon
> 
> ------------------------------------------------------------------------------
> BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
> Develop your own process in accordance with the BPMN 2 standard
> Learn Process modeling best practices with Bonita BPM through live exercises
> http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF_______________________________________________
> edk2-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/edk2-devel


------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to