On 1 May 2015 at 17:42, Olivier Martin <olivier.mar...@arm.com> wrote: > Reviewed-By: Olivier Martin <olivier.mar...@arm.com> >
Thanks! I noticed that the commit log still refers to the retained sysconfig EfiResetSystemLib, perhaps you could remove that when applying? -- Ard. > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 01 May 2015 16:36 > To: ler...@redhat.com; Olivier Martin; leif.lindh...@linaro.org; > roy.fr...@linaro.org; ge...@infradead.org; edk2-devel@lists.sourceforge.net > Cc: Ard Biesheuvel > Subject: [PATCH v3 1/2] ArmVExpressPkg: use PSCI for system reset at runtime > > Since the default EfiResetSystemLib for VExpress cannot be used at runtime > (due to the fact that its MMIO registers need to be owned by the OS and so > cannot be runtime remapped), instead use PSCI calls into EL3 at runtime. At > boot time, the original EfiResetSystemLib is retained. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc > b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc > index 8dd20ca0abc2..0bac7f6c4de9 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc > @@ -75,7 +75,6 @@ > PlatformPeiLib|ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf > > ArmPlatformSysConfigLib|ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressSysConfigLib/ArmVExpressSysConfigLib.inf > > NorFlashPlatformLib|ArmPlatformPkg/ArmVExpressPkg/Library/NorFlashArmVExpressLib/NorFlashArmVExpressLib.inf > - > EfiResetSystemLib|ArmPlatformPkg/ArmVExpressPkg/Library/ResetSystemLib/ResetSystemLib.inf > # ARM PL111 Lcd Driver > > LcdPlatformLib|ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf > # ARM PL031 RTC Driver > @@ -215,6 +214,15 @@ > > ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > > + # > + # PSCI support in EL3 may not be available if we are not running > + under a PSCI # compliant secure firmware, but since the default > + VExpress EfiResetSystemLib # cannot be supported at runtime (due to > + the fact that the syscfg MMIO registers # cannot be runtime > + remapped), it is our best bet to get ResetSystem functionality # on these > platforms. > + # > + > + EfiResetSystemLib|ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSys > + temLib.inf > + > [LibraryClasses.ARM, LibraryClasses.AARCH64] > # > # It is not possible to prevent the ARM compiler for generic intrinsic > functions. > -- > 1.9.1 > > > -- IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. > > ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, > Registered in England & Wales, Company No: 2557590 > ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, > Registered in England & Wales, Company No: 2548782 > ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
