Sorry, I meant I have feedback on the second patch.
IfrMatch2 should handle the case when there are regular expression protocol
instances, but none of them support the requested regex type GUID. The UEFI
2.5 spec specifies what to do in that case.
From: El-Haj-Mahmoud, Samer
Sent: Friday, May 01, 2015 6:45 AM
To: Jordan Justen; edk2-devel@lists.sourceforge.net; liming....@intel.com
Subject: RE: [edk2] [Patch 0/3] Enable Match2 opcode support. Also add
definition
No not all 3 patches look good. I had concerns and questions for the second
patch.
-------- Original message --------
From: Jordan Justen
<jordan.l.jus...@intel.com<mailto:jordan.l.jus...@intel.com>>
Date: 05/01/2015 2:56 AM (GMT-06:00)
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>,
"El-Haj-Mahmoud, Samer"
<samer.el-haj-mahm...@hp.com<mailto:samer.el-haj-mahm...@hp.com>>,
liming....@intel.com<mailto:liming....@intel.com>
Subject: Re: [edk2] [Patch 0/3] Enable Match2 opcode support. Also add
definition
On 2015-04-30 05:11:24, El-Haj-Mahmoud, Samer wrote:
> Patch looks good
All three patches?
You should add:
Series Reviewed-by: Samer El-Haj-Mahmoud
<samer.el-haj-mahm...@hp.com<mailto:samer.el-haj-mahm...@hp.com>>
.. if you want Eric to add your Reviewed-by to the entire patch series.
Thanks for looking over the patches!
-Jordan
> -------- Original message --------
> From: Eric Dong <eric.d...@intel.com<mailto:eric.d...@intel.com>>
> Date: 04/30/2015 12:50 AM (GMT-06:00)
> To:
> edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>,
> liming....@intel.com<mailto:liming....@intel.com>
> Subject: [edk2] [Patch 0/3] Enable Match2 opcode support. Also add definition
>
> Base on UEFI spec 2.5 request, add match2 opcode support. Also add regular
> expression protocol definition.
>
> Eric Dong (3):
> BaseTools: Enable Match2 Opcode.
> MdePkg: Add Regular Expression Protocol and match2 opcode definition.
> MdeModulePkg: Add match2 opcode support in SetupBrowserDxe and sample
> code in DriverSampleDxe.vfr
>
> .../Common/UefiInternalFormRepresentation.h | 6 +
> BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp | 3 +-
> BaseTools/Source/C/VfrCompile/VfrFormPkg.h | 17 +-
> BaseTools/Source/C/VfrCompile/VfrSyntax.g | 16 ++
> .../Universal/DriverSampleDxe/NVDataStruc.h | 1 +
> MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr | 13 ++
> .../Universal/DriverSampleDxe/VfrStrings.uni | Bin 61414 -> 62662 bytes
> .../Universal/SetupBrowserDxe/Expression.c | 171 +++++++++++++++++++-
> MdeModulePkg/Universal/SetupBrowserDxe/IfrParse.c | 9 +-
> MdeModulePkg/Universal/SetupBrowserDxe/Setup.h | 1 +
> .../Universal/SetupBrowserDxe/SetupBrowserDxe.inf | 3 +-
> .../Include/Protocol/RegularExpressionProtocol.h | 178
> +++++++++++++++++++++
> .../Include/Uefi/UefiInternalFormRepresentation.h | 6 +
> MdePkg/MdePkg.dec | 14 +-
> 14 files changed, 431 insertions(+), 7 deletions(-)
> create mode 100644 MdePkg/Include/Protocol/RegularExpressionProtocol.h
>
> --
> 1.9.5.msysgit.1
>
>
> ------------------------------------------------------------------------------
> One dashboard for servers and applications across Physical-Virtual-Cloud
> Widest out-of-the-box monitoring support with 50+ applications
> Performance metrics, stats and reports that give you Actionable Insights
> Deep dive visibility with transaction tracing using APM Insight.
> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
> https://lists.sourceforge.net/lists/listinfo/edk2-devel
>
> ------------------------------------------------------------------------------
> One dashboard for servers and applications across Physical-Virtual-Cloud
> Widest out-of-the-box monitoring support with 50+ applications
> Performance metrics, stats and reports that give you Actionable Insights
> Deep dive visibility with transaction tracing using APM Insight.
> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
> https://lists.sourceforge.net/lists/listinfo/edk2-devel
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
