> -----Original Message----- > From: Eric Dong [mailto:eric.d...@intel.com] > Sent: Tuesday, May 05, 2015 1:30 AM > To: edk2-devel@lists.sourceforge.net > Subject: [edk2] [Patch 2/3] MdeModulePkg: Implement UEFI25 HII Config keyword > handler protocol. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Eric Dong <eric.d...@intel.com> > --- > .../HiiDatabaseDxe/ConfigKeywordHandler.c | 3234 > ++++++++++++++++++++ > .../Universal/HiiDatabaseDxe/HiiDatabase.h | 223 +- > .../Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf | 4 +- > .../Universal/HiiDatabaseDxe/HiiDatabaseEntry.c | 9 +- > 4 files changed, 3467 insertions(+), 3 deletions(-) > create mode 100644 > MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c > > diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c > b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c > new file mode 100644 > index 0000000..da8bb5f > --- /dev/null > +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c [...]
This patch uses CHAR* and UINT8* interchangeably, which breaks the build for ARM, since CHAR* is signed there. In addition, there is a set but not used variable, which is also disallowed under the used GCC warning/error policy. Log output of failed build is here: https://ci.linaro.org/job/leg-virt-tianocore-edk2-upstream/52/consoleFull ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
