On 2015-05-18 19:12:49, Liu, Yingke D wrote: > Hello, > > Attached patch implemented BUILDRULEORDER feature. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Yingke Liu <yingke.d....@intel.com>
Dennis, Can you send this as a new patch separate from this thread? I think the commit message should be improved to follow: https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format === Commit message start === BaseTools: Implement BUILDRULEORDER for tools_def This feature allows the toolchain to choose a preference for source file extensions in tools_def.txt. The first extension listed is given the highest priority. Here is an example usage for tools_def.txt: *_*_*_*_BUILDRULEORDER = nasm asm S *_XCODE5_*_*_ BUILDRULEORDER = S nasm Now, if a .inf lists these sources: 1.nasm, 1.asm and 1.S All toolchains, except XCODE5 will use the 1.nasm file. The XCODE5 toolchain will use the 1.S file. Note that the build_rule.txt file also impacts the decision, because, for instance there is no build rule for .asm files on GCC toolchains. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yingke Liu <yingke.d....@intel.com> === Commit message end === I wonder if you might consider using git for these patches, since we are transitioning to git: http://www.tianocore.org/news/2015/05/01/UnderConst.html One other thing I would like to see is a second patch that makes the changes described above to the tools_def.template. Maybe Liming can help use git to do this? Thanks, -Jordan > -----Original Message----- > From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] > Sent: Wednesday, May 13, 2015 8:48 AM > To: edk2-devel@lists.sourceforge.net; Gao, Liming; Chan, Amy; Kinney, Michael > D > Cc: Davis, Brad A; Chiu, Chasel; Chaganty, Rangasai V > Subject: Re: [edk2] Basetools update for CLAN support > > Jordan, > > Yes. It is being implemented. You should start seeing details in the next > week or two. > > Mike > > -----Original Message----- > From: Jordan Justen [mailto:jordan.l.jus...@intel.com] > Sent: Monday, May 11, 2015 9:46 PM > To: Gao, Liming; edk2-devel@lists.sourceforge.net; Chan, Amy > Cc: Davis, Brad A; Chiu, Chasel; Chaganty, Rangasai V > Subject: Re: [edk2] Basetools update for CLAN support > > On 2015-05-11 21:03:14, Gao, Liming wrote: > > Jordan: > > For the feature that toolchain families to choose the priority for > > source file extensions, the design is finished. We plan to > > implement it. Once this feature is supported, I think Amy patch > > can use this way and not to remove NASM build support. > > > > BUILDRULEORDER key will be introduced for this purpose. > > The default one can be. > > *_*_*_*_BUILDRULEORDER = nasm asm S > > > > XCODE tool chain has its one. > > *_XCODE5_*_*_ BUILDRULEORDER = S nasm > > Yeah, we've had the design for 6 months now. :) Will it be implemented? > > http://permalink.gmane.org/gmane.comp.bios.tianocore.devel/11189 > > -Jordan > > ------------------------------------------------------------------------------ > One dashboard for servers and applications across Physical-Virtual-Cloud > Widest out-of-the-box monitoring support with 50+ applications Performance > metrics, stats and reports that give you Actionable Insights Deep dive > visibility with transaction tracing using APM Insight. > http://ad.doubleclick.net/ddm/clk/290420510;117567292;y > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel > > ------------------------------------------------------------------------------ > One dashboard for servers and applications across Physical-Virtual-Cloud > Widest out-of-the-box monitoring support with 50+ applications Performance > metrics, stats and reports that give you Actionable Insights Deep dive > visibility with transaction tracing using APM Insight. > http://ad.doubleclick.net/ddm/clk/290420510;117567292;y > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel > > > ------------------------------------------------------------------------------ > One dashboard for servers and applications across Physical-Virtual-Cloud > Widest out-of-the-box monitoring support with 50+ applications > Performance metrics, stats and reports that give you Actionable Insights > Deep dive visibility with transaction tracing using APM Insight. > http://ad.doubleclick.net/ddm/clk/290420510;117567292;y > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
