Thanks, Ray

I update the patch according to your comment. Please review again

Thanks
Feng

From: Ni, Ruiyu
Sent: Tuesday, May 19, 2015 14:04
To: Tian, Feng
Cc: edk2-devel@lists.sourceforge.net
Subject: RE: [patch] FatPkg: Add RecoveryBlockIo2Ppi support

Feng,
Could you please refine the code to merge the UpdateBlocksAndVolumes() and 
UpdateBlocksAndVolumes2() to one function? They are almost identical.
I recommend to change NotifyDescriptor to NotifyDescriptor[2] instead of adding 
a new field NotifyDescriptor2 to the structure PEI_FAT_PRIVATE_DATA. It means 
an array for PPIs notify.

Thanks,
Ray

From: Tian, Feng
Sent: Monday, May 18, 2015 1:06 PM
To: Ni, Ruiyu
Cc: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>; 
Tian, Feng
Subject: [patch] FatPkg: Add RecoveryBlockIo2Ppi support


Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: Feng Tian <feng.t...@intel.com<mailto:feng.t...@intel.com>>

Thanks
Feng

Attachment: FatPei.2.patch
Description: FatPei.2.patch

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to