On 20 May 2015 at 11:03, Gao, Liming <liming....@intel.com> wrote: > Hao: > I suggest to keep UINT8 for SSId field, because EFI_80211_SCAN_DATA > structure uses UINT8 as SSId. >
That is also fine by me, as long as we get this fixed. Note that the ARM builds are broken at the moment. -- Ard. > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, May 20, 2015 4:46 PM > To: edk2-devel@lists.sourceforge.net > Subject: Re: [edk2] [PATCH] MdePkg: Resolve type mismatch in node/text > conversion for Wifi device > > On 20 May 2015 at 09:56, Hao Wu <hao.a...@intel.com> wrote: >> Function DevPathFromTextWiFi() in >> MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c use UINT8* and >> CHAR8* interchangeably, which breaks the build on ARM. >> >> Since SSId is a human readable identifier, so using CHAR8 instead of >> UINT8 for SSID field in Wi-Fi Device Path definition can resovle this issue. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Hao Wu <hao.a...@intel.com> > > Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > >> --- >> MdePkg/Include/Protocol/DevicePath.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/MdePkg/Include/Protocol/DevicePath.h >> b/MdePkg/Include/Protocol/DevicePath.h >> index 7b9a4e5..121b952 100644 >> --- a/MdePkg/Include/Protocol/DevicePath.h >> +++ b/MdePkg/Include/Protocol/DevicePath.h >> @@ -904,7 +904,7 @@ typedef struct { >> /// >> /// Service set identifier. A 32-byte octets string. >> /// >> - UINT8 SSId[32]; >> + CHAR8 SSId[32]; >> } WIFI_DEVICE_PATH; >> >> // >> -- >> 1.9.5.msysgit.0 >> >> >> ---------------------------------------------------------------------- >> -------- One dashboard for servers and applications across >> Physical-Virtual-Cloud Widest out-of-the-box monitoring support with >> 50+ applications Performance metrics, stats and reports that give you >> Actionable Insights Deep dive visibility with transaction tracing >> using APM Insight. >> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/edk2-devel > > ------------------------------------------------------------------------------ > One dashboard for servers and applications across Physical-Virtual-Cloud > Widest out-of-the-box monitoring support with 50+ applications Performance > metrics, stats and reports that give you Actionable Insights Deep dive > visibility with transaction tracing using APM Insight. > http://ad.doubleclick.net/ddm/clk/290420510;117567292;y > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel > > ------------------------------------------------------------------------------ > One dashboard for servers and applications across Physical-Virtual-Cloud > Widest out-of-the-box monitoring support with 50+ applications > Performance metrics, stats and reports that give you Actionable Insights > Deep dive visibility with transaction tracing using APM Insight. > http://ad.doubleclick.net/ddm/clk/290420510;117567292;y > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
