Hi,
I build OVMF on linux (64-bit Fedora 21) using the following command:
build -a X64 -t GCC49 -p OvmfPkg/OvmfPkgX64.dsc
After commit 3bafd562b7be6c781f3f389a1e79b37268076ffa, I get the
following build error:
/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c:
In function ‘DevPathFromTextWiFi’:
/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c:2796:12:
error: pointer targets in assignment differ in signedness
[-Werror=pointer-sign]
AsciiStr = WiFiDp->SSId;
^
cc1: all warnings being treated as errors
Looking at the commit itself, this could be fixed by either using
CHAR8 SSId[32];
(instead of UINT8) in the WIFI_DEVICE_PATH typedef in
MdePkg/Include/Protocol/DevicePath.h, or by using an explicit
cast in the offending assignment in
MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c:
AsciiStr = (CHAR8 *) WiFiDp->SSId;
Personally, I'd vote for the former (unless some document explicitly
requires the SSId to be UINT8, in which case the latter fix should
work just fine.
Thanks much,
--Gabriel
PS. Apologies if this is an already-known problem, (with a patch
already pending) :)
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
