On 05/20/2015 12:56 PM, Jonathan Doman wrote: > +++ b/MdeModulePkg/Library/SlreRegExLib/SLRE/SlreUefiPort.h > ... > +#define printf(...)
Just FYI, not all compilers supported by Edk2 can use variadic macros ("..." in macro argument lists) so they would be good to avoid. The definition of _DEBUG in MdePkg/Include/Library/DebugLib.h has some discussion about this: /** Internal worker macro that calls DebugPrint(). This macro calls DebugPrint() passing in the debug error level, a format string, and a variable argument list. __VA_ARGS__ is not supported by ECB compiler, Microsoft Visual Studio .NET 2003 and Microsoft Windows Server 2003 Driver Development Kit (Microsoft WINDDK) version 3790.1830. @param Expression Expression containing an error level, a format string, and a variable argument list based on the format string. **/ #if !defined(MDE_CPU_EBC) && (!defined (_MSC_VER) || _MSC_VER > 1400) #define _DEBUG_PRINT(PrintLevel, ...) \ do { \ if (DebugPrintLevelEnabled (PrintLevel)) { \ DebugPrint (PrintLevel, ##__VA_ARGS__); \ } \ } while (FALSE) #define _DEBUG(Expression) _DEBUG_PRINT Expression #else #define _DEBUG(Expression) DebugPrint Expression #endif Thanks, -- Brian J. Johnson -------------------------------------------------------------------- My statements are my own, are not authorized by SGI, and do not necessarily represent SGI’s positions. ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel