> On May 26, 2015, at 6:56 AM, Laszlo Ersek <ler...@redhat.com> wrote: > > On 05/26/15 14:35, B Cran wrote: >> On Wed, May 13, 2015 at 11:01 AM, Peterson, Joe <joe.peter...@intel.com >> <mailto:joe.peter...@intel.com> >> <mailto:joe.peter...@intel.com <mailto:joe.peter...@intel.com>>> wrote: >> >> Sorry for the delay in responding to this. With regard to involving >> the community in a discussion of solutions, yes, there is no >> intention of making this an "Intel only" thing. The posting of the >> list shouldn't be seen as "this is what will be done," rather, this >> is the list we have developed based upon feedback from the community >> to date. If you have feedback or know of anything we missed, please >> provide your feedback here via the mailing list. Also, we do not >> intend to make this a home grown solution if we can avoid it. >> >> Please be encouraged to post questions/comment/concerns to the >> mailing list. >> >> >> I don't know how many others feel similarly, but I've seen very negative >> feedback on Gerrit in the past at $work, mostly around its unfriendly >> and ugly UI. If a code review system is going to be put into place, it >> might make sense to use something that's more popular, in use by more >> open source projects? > > Nothing comes close to reviews done in email (*). As I stated earlier > elsewhere: > > - No web based application will ever be as flexible as free flowing text > for expressing thoughts about patches. I skimmed some upstream Gerrit > page / examples before, and what I saw could certainly not accommodate > the amount & format of text (eg. ASCII diagrams) that I > sometimes produce. > > - Mailing lists are unbeaten at preserving threading, and at being > archived / mirrored without coordination. > > (*) assuming (a) contributors use git-send-email to post patches, and > (b) reviewers use sensible MUAs that don't mangle plaintext, > monospace font emails. > > Gerrit may be okay for tight-knit internal teams, but for > distributed development it's not appropriate in my opinion. Unless I'm > wrong, Gerrit has been designed for in-house development, from the > grounds up. > > I don't intend to use Gerrit, and I very much hope that all contributors > will continue posting patches to, and accepting feedback from, the list. >
Is it possible to do both? So the Gerrit part is just a link that is auto added to the commit message? I’ve only played with Gerrit one time, so I may be way off…. But this would be cool. 1) Submit patch to Gerrit, much like we do today to the mailing list. 2) Gerrit runs that patch against the server farm of known compilers and makes sure everything compiles. Kicks back the patch to the author on a build fail. 3) If everything compiles patch is sent to edk2 mailing list with link to Gerrit auto-added. We can still required all the comments happen in the mailing list. To me the win for Gerrit is workflow automation, getting to test compile against other tools. Also I’m a visual diff kind of person, so my brain likes seeing the visual diff of the change, vs a command line diff. It would be nice to have access to this on the web, vs. having to apply the patch to branch manually. Thanks, Andrew Fish > Thanks > Laszlo > > >> Also, are there any plans to open up the >> tianocore.org <http://tianocore.org/> <http://tianocore.org >> <http://tianocore.org/>> site to other contributors, so >> anyone (or at least active edk2-devel members) can contribute and edit >> the pages? >> >> Bruce >> >> >> ------------------------------------------------------------------------------ >> One dashboard for servers and applications across Physical-Virtual-Cloud >> Widest out-of-the-box monitoring support with 50+ applications >> Performance metrics, stats and reports that give you Actionable Insights >> Deep dive visibility with transaction tracing using APM Insight. >> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y >> >> >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/edk2-devel >> > > > ------------------------------------------------------------------------------ > One dashboard for servers and applications across Physical-Virtual-Cloud > Widest out-of-the-box monitoring support with 50+ applications > Performance metrics, stats and reports that give you Actionable Insights > Deep dive visibility with transaction tracing using APM Insight. > http://ad.doubleclick.net/ddm/clk/290420510;117567292;y > <http://ad.doubleclick.net/ddm/clk/290420510;117567292;y> > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net <mailto:edk2-devel@lists.sourceforge.net> > https://lists.sourceforge.net/lists/listinfo/edk2-devel > <https://lists.sourceforge.net/lists/listinfo/edk2-devel>
------------------------------------------------------------------------------
_______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
