Follow the discussion below, the patch is to enhance DxeSmmPerformanceLib to support dump PEI/DXE/SMM performance data altogether. Help review it, please.
Thanks, Star From: Yao, Jiewen [mailto:jiewen....@intel.com] Sent: Thursday, April 16, 2015 10:59 AM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] SmmCorePerformanceLib Understood. I agree. Thank you Yao Jiewen From: Zeng, Star [mailto:star.z...@intel.com] Sent: Thursday, April 16, 2015 10:47 AM To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net> Subject: Re: [edk2] SmmCorePerformanceLib Thanks for all your comments, and we will take effort to enhance the DxeSmmPerformanceLib library instance. For name, I think DxeSmmPerformanceLib is ok. First, for compatibility. Second, this library instance will to consume performanceprotocol and smmcommunication to get performance data, DxeCorePerforamnceLib will collect PEI and DXE performance data, but it doesn't have PEI prefix, DxePerformanceLib consumes performanceprotocol also has no PEI prefix. Thanks, Star From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Thursday, April 16, 2015 10:34 AM To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net> Subject: Re: [edk2] SmmCorePerformanceLib Yes, that would be helpful to have single UEFI application to provide timing info of all the drivers. Thanks. -Baranee From: Yao, Jiewen [mailto:jiewen....@intel.com] Sent: Wednesday, April 15, 2015 8:52 PM To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net> Subject: Re: [edk2] SmmCorePerformanceLib That would be great. Do you think PeiDxeSmmPerformance will be better name for that? :) Thank you Yao Jiewen From: Zeng, Star [mailto:star.z...@intel.com] Sent: Thursday, April 16, 2015 9:34 AM To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net> Subject: Re: [edk2] SmmCorePerformanceLib Yes, DxeSmmPerformance should could be enhanced to support dump PEI/DXE/SMM performance data altogether. Thanks, Star From: Yao, Jiewen [mailto:jiewen....@intel.com] Sent: Thursday, April 16, 2015 9:15 AM To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net> Subject: Re: [edk2] SmmCorePerformanceLib Hi I do not think it is good design. Can we have one library instance to dump PEI/DXE/SMM performance data altogether? If so, it will make developer easy to view all perf data in one place. Thank you Yao Jiewen From: Zeng, Star [mailto:star.z...@intel.com] Sent: Thursday, April 16, 2015 8:44 AM To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net> Subject: Re: [edk2] SmmCorePerformanceLib It depends on which PerformanceLib the DP application linked. For example, if DxePerfrmanceLib(MdeModulePkg\Library\DxePerformanceLib) got linked, it will try to dump PEI and DXE performance data; and if DxeSmmPerfrmanceLib(MdeModulePkg\Library\DxeSmmPerformanceLib) got linked, then SMM performance data expected. Thanks, Star From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Thursday, April 16, 2015 5:02 AM To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net> Subject: Re: [edk2] SmmCorePerformanceLib Thanks for the update. Whether current DP application provide timing of all drivers? Or we need separate application to measure SMM drivers since DP application is tied to PerformanceLib. -Baranee From: Zeng, Star [mailto:star.z...@intel.com] Sent: Tuesday, April 14, 2015 7:41 PM To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net> Subject: Re: [edk2] SmmCorePerformanceLib You need to use PiSmmCoreSmmServicesTableLib SmmServicesTableLib instance. From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Tuesday, April 14, 2015 8:30 PM To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net> Subject: [edk2] SmmCorePerformanceLib SmmCorePerformaceLib is using SmmServicesTableLib which cannot be used in SMM_CORE modules(SVN#10183) and leads to build error. SmmCorePerformaceLib needs to access SmmAllocatePool, SmmInstallProtocolInterface and SmiHandlerRegister without gSmst - either integrate SmmCorePerformaceLib as part of PiSmmCore or mark those functions as extern. -Baranee CONFIDENTIALITY NOTICE: The information contained in this e-mail and any accompanying documents may contain information which is HP confidential or otherwise protected from disclosure. This transmission may also be protected by the attorney-client privilege, the attorney work-product privilege, or both. If you are not the intended recipient of this message, or if this message has been addressed to you in error, please immediately alert the sender by reply e-mail and then delete this message, including any attachments. Any dissemination, distribution or other use of the contents of this message by anyone other than the intended recipient is strictly prohibited.
0001-MdeModulepkg-DxeSmmPerformanceLib-Dump-all-PEI-DXE-S.patch
Description: 0001-MdeModulepkg-DxeSmmPerformanceLib-Dump-all-PEI-DXE-S.patch
------------------------------------------------------------------------------
_______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
