> On Jun 10, 2015, at 6:33 PM, Carsey, Jaben <jaben.car...@intel.com> wrote: > > Andrew, > > I agree, that looks like an issue. Can you submit a patch with this fixed?
Sorry don’t have time right now. > I will put this on the list of issues. > Thanks, I hit this issue in another location and look to see what the shell did. Since the shell seemed to be doing the wrong thing I decided to at least report it to the mailing list. I’m guessing more modern filesystems probably store the time in UTC? Thanks, Andrew Fish > -Jaben > >> -----Original Message----- >> From: Andrew Fish [mailto:af...@apple.com] >> Sent: Wednesday, June 10, 2015 6:26 PM >> To: edk2-devel@lists.sourceforge.net >> Subject: [edk2] [ShellPkg] I think there is an issue in ls. >> Importance: High >> >> Dear ShellPkg maintainer, >> >> I think there is an issue with the ls command. It does not use the TImeZone, >> so it seems it is hard coded to assume that a filesystem stores time like >> FAT, in >> local time. The FAT driver always returns EFI_UNSPECIFIED_TIMEZONE, which >> implies the values are local time. But what if a filesystem is storing time >> in UTC >> (EFI_TIME.TimeZone == 0)? it seems the current path in the shell assumes >> EFI_UNSPECIFIED_TIMEZONE (thus all time is local time). I don’t think this >> follows the UEFI spec. I think the correct algorithm is: >> >> if FileSystemTime.TimeZone == EFI_UNSPECIFIED_TIMEZONE >> // This is the current path in the code >> Assume time is local time, and print it out >> else: >> // This is the missing path. >> Adjust the FileSystemTime.TimeZone for the System.TimeZone (and >> System.Daylight), thus display the time in local time. >> >> Thanks, >> >> Andrew Fish >> >> >> ------------------------------------------------------------------------------ >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/edk2-devel > ------------------------------------------------------------------------------ > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
