On 06/18/15 15:11, Ard Biesheuvel wrote:
> Remove two instances of 'DHCP_SERVICE *DhcpSb' in function scope
> that are assigned but never used afterwards.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org>
> ---
> MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
> b/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
> index ac4b11f09402..821dfbb450a7 100644
> --- a/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
> +++ b/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
> @@ -1188,7 +1188,6 @@ Dhcp4InstanceConfigUdpIo (
> )
> {
> DHCP_PROTOCOL *Instance;
> - DHCP_SERVICE *DhcpSb;
> EFI_DHCP4_TRANSMIT_RECEIVE_TOKEN *Token;
> EFI_UDP4_CONFIG_DATA UdpConfigData;
> IP4_ADDR ClientAddr;
> @@ -1197,7 +1196,6 @@ Dhcp4InstanceConfigUdpIo (
> IP4_ADDR SubnetMask;
>
> Instance = (DHCP_PROTOCOL *) Context;
> - DhcpSb = Instance->Service;
> Token = Instance->Token;
>
> ZeroMem (&UdpConfigData, sizeof (EFI_UDP4_CONFIG_DATA));
> @@ -1309,7 +1307,6 @@ PxeDhcpInput (
> )
> {
> DHCP_PROTOCOL *Instance;
> - DHCP_SERVICE *DhcpSb;
> EFI_DHCP4_HEADER *Head;
> NET_BUF *Wrap;
> EFI_DHCP4_PACKET *Packet;
> @@ -1320,7 +1317,6 @@ PxeDhcpInput (
> Wrap = NULL;
> Instance = (DHCP_PROTOCOL *) Context;
> Token = Instance->Token;
> - DhcpSb = Instance->Service;
>
> //
> // Don't restart receive if error occurs or DHCP is destroyed.
>
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
Thanks for picking this up, Ard -- this repeated breakage is annoying,
especially after Scott has made available prebuilt gcc toolchains for
Windows-based developers:
http://sourceforge.net/projects/edk2developertoolsforwindows/files/Tool%20Chain%20Binaries/
which could be used to weed out such issues. I guess people first have
to learn to care about the community.
I couldn't find it in me this time to write and post the fix, so thanks
again for doing this.
Laszlo
------------------------------------------------------------------------------
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
