On Fri, Jun 19, 2015 at 6:04 AM, Laszlo Ersek <ler...@redhat.com> wrote: > On 06/19/15 07:16, Roy Franz wrote: >> When I rebased my TtyTerm changes, I found that I had been working on >> a rather out of date Linaro branch without realizing it. After >> rebasing my patchset, the >> gArmPlatformTokenSpaceGuid.PcdDefaultConOutPaths PCD only controls the >> console for the ARM BDS, and doesn't affect the Intel BDS. (Changes >> seem to be in commit ba67a145410) >> I poked around a bit and and didn't see where the terminal type was >> configured for the Intel BDS. >> Where should I look for this? > > Please see the "mSerialConsole" object in > > ArmVirtPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c > > You might want to overide the > > mSerialConsole.Vt100.Guid > > field conditionally; its value is now EFI_VT_100_GUID statically.
What is the preferred method for doing this? I don't see a way to directly put a GUID in a PCD so that I could use that to initialize the static structure. Since as I understand it mSerialConsole is a statically constructed device path, would it be reasonable to use a PCD for the entire path (as in the ARM BDS case), and simply call BdsLibUpdateConsoleVariable() with the PCD, if present, rather than mSerialConsole? > > (And then renaming the "Vt100" field itself to something more generic > might make sense too.) > > ... As I said, please don't change the default behavior. I know you don't like this, but I think there is a reasonable argument to be made that most people would benefit from this change. I expect the new setting to be the default in the Linaro builds. I'm not going push hard for a default change - others who have broken backspace will have to chime in :) Thanks for all your help, Roy > > For more background, please refer to: > > commit 60dc18a17c51697be6a06e2ec1944a0d8b06d501 > Author: Laszlo Ersek <ler...@redhat.com> > Date: Wed Feb 25 17:54:05 2015 +0000 > > ArmVirtualizationPkg: PlatformIntelBdsLib: detect consoles dynamically > > Thanks > Laszlo ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
