On 06/23/15 01:30, Roy Franz wrote: > This patchset is a followup to my previous backspace/LinuxTerm patchsets. > It adds a new terminal type "TtyTerm", that better handles > the typical Linux terminal (xterm/rxvt/gnome terminal/etc.) > These often treat backspace/delete differently than the > existing EDK2 terminal types expect, particularly in emulated > environments where the emulated serial port is connected > to a graphical terminal rather than a serial console. > > This patchset includes changes to make the terminal type build time > configurable > for the QEMU Aarch64 configuration. Once this patchset goes in I will submit > patches for the other emulated ARM platforms as appropriate. > > > Changes from LinuxTerm RFC patchset: > * Change to ttyTerm name - nothing linux specific in patchset > * remove changes to Mde module, as changes not part of UEFI specification > > Laszlo Ersek (1): > Add PCD for selecting terminal type > > Roy Franz (3): > Add "TtyTerm" terminal type to TerminalDxe > Treat ASCII 0x7F as backspace for TtyTerm terminals > accept [3~ as delete for TtyTerm terminals
(I'm at fault partly because I sent you a raw diff last time, without any kind of subject / commit message. Anyway,) please prefix subject lines with the respective package names, and (if you've got enough room to squeeze that too in 74 characters) the library / driver name is helpful as well. Something like: MdeModulePkg: TerminalDxe: add TtyTerm terminal type MdeModulePkg: TerminalDxe: treat ASCII 0x7F as backspace for TtyTerm MdeModulePkg: TerminalDxe: accept (0x5B 0x33 0x7E) as delete for TtyTerm ArmVirtPkg: PlatformIntelBdsLib: add PCD for selecting terminal type (You can replace the first ": " string with "/" if you prefer that.) Regarding the "[3~" --> "(0x5B 0x33 0x7E)" change in the third patch's subject: I'm a bit worried about the opening bracket *outside* of the bag-of-tags subject prefix (ie. outside of "[PATCH 3/4]"). I'm concerned some patch-handling tools might choke on that bracket, hence the idea to describe the ASCII in hex. Thanks! Laszlo > ArmVirtPkg/ArmVirt.dsc.inc | 6 ++++++ > ArmVirtPkg/ArmVirtPkg.dec | 7 +++++++ > ArmVirtPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c | 12 > ++++++++---- > ArmVirtPkg/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf | 4 ++++ > MdeModulePkg/Include/Guid/TtyTerm.h | 25 > +++++++++++++++++++++++++ > MdeModulePkg/MdeModulePkg.dec | 3 +++ > MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c | 44 > +++++++++++++++++++++++++++++++++++++------- > MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h | 3 +++ > MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c | 47 > ++++++++++++++++++++++++++++++++++++++++++++--- > MdeModulePkg/Universal/Console/TerminalDxe/TerminalConOut.c | 2 ++ > MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf | 1 + > 11 files changed, 140 insertions(+), 14 deletions(-) > create mode 100644 MdeModulePkg/Include/Guid/TtyTerm.h > ------------------------------------------------------------------------------ Monitor 25 network devices or servers for free with OpManager! OpManager is web-based network management software that monitors network devices and physical & virtual servers, alerts via email & sms for fault. Monitor 25 devices for free with no restriction. Download now http://ad.doubleclick.net/ddm/clk/292181274;119417398;o _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
