Good. So many emails in the Inbox, unfortunately I missed it previously, fortunately you make me know it now. Thanks for that.
Star -----Original Message----- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Monday, June 29, 2015 6:39 PM To: Zeng, Star Cc: edk2-devel@lists.sourceforge.net; Ard Biesheuvel Subject: Re: [PATCH V3 12/25] ArmVirtPkg: Link AuthVariableLib for following merged variable driver deploy comments below On 06/29/15 12:08, Star Zeng wrote: > AuthVariableLib and TpmMeasurementLib library classes are now linked > with MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf > to optionally support secure variables. > > For ArmVirtPkg, > link AuthVariableLib and DxeTpmMeasurementLib in SecurityPkg when > SECURE_BOOT_ENABLE = TRUE, and link AuthVariableLibNull and > TpmMeasurementLibNull in MdeModulePkg when SECURE_BOOT_ENABLE = FALSE. > > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Star Zeng <star.z...@intel.com> > --- > ArmVirtPkg/ArmVirt.dsc.inc | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index c6e684f..7ec0de4 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -1,6 +1,7 @@ > # > # Copyright (c) 2011-2015, ARM Limited. All rights reserved. > # Copyright (c) 2014, Linaro Limited. All rights reserved. > +# Copyright (c) 2015, Intel Corporation. All rights reserved. > # > # This program and the accompanying materials # are licensed and > made available under the terms and conditions of the BSD License @@ > -120,10 +121,14 @@ > IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > > TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasu > rementLib.inf > + > + AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib. > + inf > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > > # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree > > PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib. > inf > +!else > + > +TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasu > +rementLibNull.inf > + > +AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariable > +LibNull.inf > !endif > > [LibraryClasses.common.SEC] > Specifically for this patch: Reviewed-by: Laszlo Ersek <ler...@redhat.com> In general: Star, it's great that you have migrated to git so quickly and extensively. I'd like to ask you to tweak your git config a little bit further: http://sourceforge.net/p/edk2/mailman/message/34190505/ Because, for ease of review, the hunk headers above (@@) should have named the specific section of the ArmVirt.dsc.inc file being modified. Thanks! Laszlo ------------------------------------------------------------------------------ Monitor 25 network devices or servers for free with OpManager! OpManager is web-based network management software that monitors network devices and physical & virtual servers, alerts via email & sms for fault. Monitor 25 devices for free with no restriction. Download now http://ad.doubleclick.net/ddm/clk/292181274;119417398;o _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
