Reviewed-by: Liming Gao <liming....@intel.com>
-----Original Message-----
From: Yingke Liu [mailto:yingke.d....@intel.com]
Sent: Tuesday, June 30, 2015 10:15 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch] BaseTools: Do not create an empty file if
Rsa2048Sha256Sign was failed.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yingke Liu <yingke.d....@intel.com>
---
.../Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256Sign.py | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/BaseTools/Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256Sign.py
b/BaseTools/Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256Sign.py
index b83c9d4..b3254d8 100644
--- a/BaseTools/Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256Sign.py
+++ b/BaseTools/Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256Sign.py
@@ -65,7 +65,7 @@ if __name__ == '__main__':
group = parser.add_mutually_exclusive_group(required=True)
group.add_argument("-e", action="store_true", dest='Encode', help='encode
file')
group.add_argument("-d", action="store_true", dest='Decode', help='decode
file')
- parser.add_argument("-o", "--output", dest='OutputFile',
type=argparse.FileType('wb'), metavar='filename', help="specify the output
filename", required=True)
+ parser.add_argument("-o", "--output", dest='OutputFile', type=str,
+ metavar='filename', help="specify the output filename", required=True)
parser.add_argument("--private-key", dest='PrivateKeyFile',
type=argparse.FileType('rb'), help="specify the private key filename. If not
specified, a test signing key is used.")
parser.add_argument("-v", "--verbose", dest='Verbose', action="store_true",
help="increase output messages")
parser.add_argument("-q", "--quiet", dest='Quiet', action="store_true",
help="reduce output messages") @@ -110,10 +110,13 @@ if __name__ == '__main__':
args.InputFile.close()
#
- # Save output filename and close output file
+ # Save output filename and check if path exists
#
- args.OutputFileName = args.OutputFile.name
- args.OutputFile.close()
+ OutputDir = os.path.dirname(args.OutputFile) if not
+ os.path.exists(OutputDir):
+ print 'ERROR: The output path does not exist: %s' % OutputDir
+ sys.exit(1)
+ args.OutputFileName = args.OutputFile
#
# Save private key filename and close private key file
--
1.9.5.msysgit.0
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
