Bruce: The patch is good Reviewed-by： Chao Zhang <[email protected]>
Thanks & Best regards Chao Zhang -----Original Message----- From: Bruce Cran [mailto:[email protected]] Sent: Tuesday, July 07, 2015 10:22 AM To: Zhang, Chao B; [email protected] Cc: Bruce Cran Subject: [PATCH] Fix type cast of ~0 in CheckSignatureListFormat: SigHeaderSize is UINT32 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bruce Cran <[email protected]> --- SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c b/SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c index 566c5e2..885b916 100644 --- a/SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c +++ b/SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c @@ -949,7 +949,7 @@ CheckSignatureListFormat( (SigList->SignatureSize - sizeof (EFI_GUID)) != mSupportSigItem[Index].SigDataSize) { return EFI_INVALID_PARAMETER; } - if (mSupportSigItem[Index].SigHeaderSize != ((UINTN) ~0) && + if (mSupportSigItem[Index].SigHeaderSize != ((UINT32) ~0) && SigList->SignatureHeaderSize != mSupportSigItem[Index].SigHeaderSize) { return EFI_INVALID_PARAMETER; } -- 2.4.5 ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
