Reviewed-by: Qiu Shumin <shumin....@intel.com>
-----Original Message----- From: Bruce Cran [mailto:br...@cran.org.uk] Sent: Tuesday, July 07, 2015 10:20 AM To: Carsey, Jaben; Qiu, Shumin; edk2-devel@lists.sourceforge.net Cc: Bruce Cran Subject: [PATCH] Fix typo of 'determines' in ShellPkg Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bruce Cran <br...@cran.org.uk> --- ShellPkg/Application/Shell/Shell.c | 4 ++-- ShellPkg/Application/Shell/Shell.h | 2 +- ShellPkg/Include/Protocol/EfiShellEnvironment2.h | 6 +++--- ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | 4 ++-- ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c | 2 +- ShellPkg/Library/UefiShellLib/UefiShellLib.c | 2 +- ShellPkg/ShellPkg.dec | 8 ++++---- 7 files changed, 14 insertions(+), 14 deletions(-) diff --git a/ShellPkg/Application/Shell/Shell.c b/ShellPkg/Application/Shell/Shell.c index 7a89f02..2e9c7f3 100644 --- a/ShellPkg/Application/Shell/Shell.c +++ b/ShellPkg/Application/Shell/Shell.c @@ -2507,7 +2507,7 @@ RunCommand( STATIC CONST UINT16 InvalidChars[] = {L'*', L'?', L'<', L'>', L'\\', L'/', L'\"', 0x0001, 0x0002}; /** - Function determins if the CommandName COULD be a valid command. It does not determine whether + Function determines if the CommandName COULD be a valid command. It + does not determine whether this is a valid command. It only checks for invalid characters. @param[in] CommandName The name to check @@ -2928,4 +2928,4 @@ FindFirstCharacter( } } return (String + StrLen(String)); -} \ No newline at end of file +} diff --git a/ShellPkg/Application/Shell/Shell.h b/ShellPkg/Application/Shell/Shell.h index 0a55f79..ee706b8 100644 --- a/ShellPkg/Application/Shell/Shell.h +++ b/ShellPkg/Application/Shell/Shell.h @@ -295,7 +295,7 @@ RunCommand( ); /** - Function determins if the CommandName COULD be a valid command. It does not determine whether + Function determines if the CommandName COULD be a valid command. It + does not determine whether this is a valid command. It only checks for invalid characters. @param[in] CommandName The name to check diff --git a/ShellPkg/Include/Protocol/EfiShellEnvironment2.h b/ShellPkg/Include/Protocol/EfiShellEnvironment2.h index 05ec69d..1aa1b7e 100644 --- a/ShellPkg/Include/Protocol/EfiShellEnvironment2.h +++ b/ShellPkg/Include/Protocol/EfiShellEnvironment2.h @@ -320,7 +320,7 @@ EFI_SHELL_INTERFACE* ); /** - This function determins whether a script file is currently being processed. + This function determines whether a script file is currently being processed. A script file (.nsh file) can contain a series of commands and this is useful to know for some shell commands whether they are being run manually or as part of a @@ -420,7 +420,7 @@ UINT32 ); /** - This function determins if the shell application should break. + This function determines if the shell application should break. This is used to inform a shell application that a break condition has been initiated. Long loops should check this to prevent delays to the break. @@ -455,7 +455,7 @@ VOID ); /** - This function determins if the caller is running under the root shell. + This function determines if the caller is running under the root shell. @retval TRUE The caller is running under the root shell. @retval FALSE The caller is not running under the root shell. diff --git a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c index 74d4d9e..b8193e8 100644 --- a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c +++ b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c @@ -892,7 +892,7 @@ ShellCommandIsOnAliasList( } /** - Function to determine current state of ECHO. Echo determins if lines from scripts + Function to determine current state of ECHO. Echo determines if + lines from scripts and ECHO commands are enabled. @retval TRUE Echo is currently enabled @@ -908,7 +908,7 @@ ShellCommandGetEchoState( } /** - Function to set current state of ECHO. Echo determins if lines from scripts + Function to set current state of ECHO. Echo determines if lines from + scripts and ECHO commands are enabled. If State is TRUE, Echo will be enabled. diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c b/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c index e9a3ff4..1dad87d 100644 --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c @@ -187,7 +187,7 @@ CascadeDelete( } /** - Determins if a Node is a valid delete target. Will prevent deleting the root directory. + Determines if a Node is a valid delete target. Will prevent deleting the root directory. @param[in] List RESERVED. Not used. @param[in] Node The node to analyze. diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c b/ShellPkg/Library/UefiShellLib/UefiShellLib.c index 5e03400..535def6 100644 --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c @@ -2506,7 +2506,7 @@ ShellCommandLineGetCount( } /** - Determins if a parameter is duplicated. + Determines if a parameter is duplicated. If Param is not NULL then it will point to a callee allocated string buffer with the parameter value if a duplicate is found. diff --git a/ShellPkg/ShellPkg.dec b/ShellPkg/ShellPkg.dec index 3bd4159..9d8b7a9 100644 --- a/ShellPkg/ShellPkg.dec +++ b/ShellPkg/ShellPkg.dec @@ -107,7 +107,7 @@ ## This is the character count for allocation for consistent mappings gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength|50|UINT8|0x00000009 - ## This determins how many bytes are read out of files at a time for file operations (type, copy, etc...) + ## This determines how many bytes are read out of files at a time for + file operations (type, copy, etc...) gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize|1000|UINT32|0x0000000A [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] @@ -115,13 +115,13 @@ # If TRUE the shell will produce EFI_SHELL_ENVIRONMENT2 and EFI_SHELL_INTERFACE gEfiShellPkgTokenSpaceGuid.PcdShellSupportOldProtocols|FALSE|BOOLEAN|0x00000002 - ## this flag determins whether Page Break (-b) defaults to on or off in the shell + ## this flag determines whether Page Break (-b) defaults to on or off + in the shell gEfiShellPkgTokenSpaceGuid.PcdShellPageBreakDefault|FALSE|BOOLEAN|0x00000006 - ## this flag determins whether insert mode for typing is default (FALSE means typeover) + ## this flag determines whether insert mode for typing is default + (FALSE means typeover) gEfiShellPkgTokenSpaceGuid.PcdShellInsertModeDefault|TRUE|BOOLEAN|0x00000007 - ## this flag determins the default number of screens kept for history log. + ## this flag determines the default number of screens kept for history log. # the spec defines 3 as the minimum gEfiShellPkgTokenSpaceGuid.PcdShellScreenLogCount|3|UINT8|0x00000008 -- 2.4.5 ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
