On 07/07/15 03:33, Wu, Jiaxin wrote:
> Hi all,
> Ip4ConfigDxe driver is deprecated in UEFI 2.5, so we will not support
> original Ip4Config Protocol, which is replace by Ip4Config2 Protocol
> integrated in Ip4Dxe driver.
>
> Related pkgs(MdeModulePkg, Nt32Pkg, ArmPlatformPkg, ArmVirtPkg,
> EmulatorPkg, OvmfPkg, Vlv2TbltDevicePkg) need to remove Ip4ConfigDxe
> module and related guid definitions, otherwise they will meet build
> failure issue after we update Ip4Dxe driver and deprecate
> Ip4ConfigDxe driver.
>
> I have created corresponding patches to remove this dependency. Please help
> to review them.
>
> If there is any omission, please make supplement or correction.
Whenever you modify code under a top level package (like ArmVirtPkg or
OvmfPkg), please consult the Maintainers.txt file in the root directory
of the project, and then Cc those people inside the commit message. The
"git send-email" utility will then make sure that the patches in
question will be mailed to the maintainers directly.
In particular, your patch
[edk2] [Patch 3/7] OvmfPkg: Remove Ip4ConfigDxe module from OvmfPkg.
should have said in the commit message, above you Contributed-under tag:
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Cc: Laszlo Ersek <ler...@redhat.com>
similarly in
[edk2] [Patch 5/7] ArmVirtPkg: Remove Ip4ConfigDxe module from
ArmVirtPkg.
there should have been
Cc: Laszlo Ersek <ler...@redhat.com>
Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>
We have a lot of traffic on the list now, and package maintainers should
be Cc'd directly on patches that modify their packages. This carbon copy
can be realized in different ways; one of them is adding the Cc: tags to
the commit messages, and posting the patches with a utility (like git
send-email) that adheres to the Cc: tags.
Thanks
Laszlo
>
> Thanks.
> Jiaxin
>
>
> -----Original Message-----
> From: jiaxinwu [mailto:jiaxin...@intel.com]
> Sent: Tuesday, July 7, 2015 9:28 AM
> To: edk2-devel@lists.sourceforge.net
> Subject: [edk2] [Patch 0/7] Remove Ip4ConfigDxe module and related guid
> definitions from related packages.
>
> Those patches are used to remove Ip4ConfigDxe module and related guid
> definitions from related packages.
>
> jiaxinwu (7):
> MdeModulePkg: Remove Ip4ConfigDxe module and related guid definition
> from MdeModulePkg.
> Nt32Pkg: Remove Ip4ConfigDxe module from Nt32Pkg.
> OvmfPkg: Remove Ip4ConfigDxe module from OvmfPkg.
> ArmPlatformPkg: Remove Ip4ConfigDxe module from ArmPlatformPkg.
> ArmVirtPkg: Remove Ip4ConfigDxe module from ArmVirtPkg.
> EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg.
> Vlv2TbltDevicePkg: Remove Ip4ConfigDxe module from Vlv2TbltDevicePkg.
>
> ArmPlatformPkg/ArmJunoPkg/ArmJuno.fdf | 1 -
> .../ArmVExpressPkg/ArmVExpress-CTA15-A7.fdf | 1 -
> .../ArmVExpressPkg/ArmVExpress-CTA9x4.fdf | 1 -
> .../ArmVExpressPkg/ArmVExpress-RTSM-A15.fdf | 1 -
> .../ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.fdf | 1 -
> ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc | 1 -
> ArmVirtPkg/ArmVirt.dsc.inc | 1 -
> ArmVirtPkg/ArmVirtQemu.fdf | 1 -
> EmulatorPkg/EmulatorPkg.dsc | 1 -
> EmulatorPkg/EmulatorPkg.fdf | 3 +-
> MdeModulePkg/Include/Guid/Ip4ConfigHii.h | 25 -
> MdeModulePkg/Include/Guid/NicIp4ConfigNvData.h | 70 --
> MdeModulePkg/MdeModulePkg.dec | 6 -
> MdeModulePkg/MdeModulePkg.dsc | 1 -
> .../Universal/Network/Ip4ConfigDxe/ComponentName.c | 165 ----
> .../Universal/Network/Ip4ConfigDxe/Ip4Config.c | 745 -----------------
> .../Universal/Network/Ip4ConfigDxe/Ip4Config.h | 533 ------------
> .../Network/Ip4ConfigDxe/Ip4ConfigDriver.c | 505 ------------
> .../Network/Ip4ConfigDxe/Ip4ConfigDxe.inf | 91 ---
> .../Network/Ip4ConfigDxe/Ip4ConfigDxe.uni | Bin 2700 -> 0 bytes
> .../Network/Ip4ConfigDxe/Ip4ConfigDxe.vfr | 89 --
> .../Network/Ip4ConfigDxe/Ip4ConfigDxeExtra.uni | Bin 1366 -> 0 bytes
> .../Network/Ip4ConfigDxe/Ip4ConfigDxeStrings.uni | Bin 3000 -> 0 bytes
> .../Universal/Network/Ip4ConfigDxe/Ip4ConfigNv.c | 909
> ---------------------
> .../Universal/Network/Ip4ConfigDxe/Ip4ConfigNv.h | 54 --
> .../Universal/Network/Ip4ConfigDxe/Ip4NvData.h | 48 --
> .../Network/Ip4ConfigDxe/NicIp4Variable.c | 319 --------
> .../Network/Ip4ConfigDxe/NicIp4Variable.h | 104 ---
> Nt32Pkg/Nt32Pkg.dsc | 1 -
> Nt32Pkg/Nt32Pkg.fdf | 1 -
> OvmfPkg/OvmfPkgIa32.dsc | 1 -
> OvmfPkg/OvmfPkgIa32.fdf | 1 -
> OvmfPkg/OvmfPkgIa32X64.dsc | 1 -
> OvmfPkg/OvmfPkgIa32X64.fdf | 1 -
> OvmfPkg/OvmfPkgX64.dsc | 1 -
> OvmfPkg/OvmfPkgX64.fdf | 1 -
> Vlv2TbltDevicePkg/PlatformPkg.fdf | 1 -
> Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 1 -
> Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1 -
> Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 -
> Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 -
> 41 files changed, 1 insertion(+), 3688 deletions(-) delete mode 100644
> MdeModulePkg/Include/Guid/Ip4ConfigHii.h
> delete mode 100644 MdeModulePkg/Include/Guid/NicIp4ConfigNvData.h
> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/ComponentName.c
> delete mode 100644 MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4Config.c
> delete mode 100644 MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4Config.h
> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDriver.c
> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxe.inf
> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxe.uni
> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxe.vfr
> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxeExtra.uni
> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxeStrings.uni
> delete mode 100644 MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigNv.c
> delete mode 100644 MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigNv.h
> delete mode 100644 MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4NvData.h
> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/NicIp4Variable.c
> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/NicIp4Variable.h
>
> --
> 1.9.5.msysgit.1
>
>
> ------------------------------------------------------------------------------
> Don't Limit Your Business. Reach for the Cloud.
> GigeNET's Cloud Solutions provide you with the tools and support that
> you need to offload your IT needs and focus on growing your business.
> Configured For All Businesses. Start Your Cloud Today.
> https://www.gigenetcloud.com/
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel
>
> ------------------------------------------------------------------------------
> Don't Limit Your Business. Reach for the Cloud.
> GigeNET's Cloud Solutions provide you with the tools and support that
> you need to offload your IT needs and focus on growing your business.
> Configured For All Businesses. Start Your Cloud Today.
> https://www.gigenetcloud.com/
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel
>
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
